Bug 11685

Summary: GetSupportName and GetSupportList do not split AdvancedSearchTypes by pipe
Product: Koha Reporter: paxed <pasi.kallinen>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: CLOSED INVALID QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: jonathan.druart, veron
Version: Main   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12136
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:

Description paxed 2014-02-05 07:31:47 UTC
System preference AdvancedSearchTypes can be a pipe-separated list of values.
GetSupportName() and GetSupportList() compare the syspref value directly using eq instead of using a regex, or splitting the value by pipe and then comparing the array values.

For example, this can mean the "Item type" drop down is empty in OPAC when entering a new purchase suggestion.
Comment 1 paxed 2014-04-24 09:36:46 UTC
In addition to GetSupportName(), GetSupportList() in C4/Koha.pm, also opac/opac-topissues.pl handles the syspref wrongly.
Comment 2 Marc Véron 2014-04-24 19:04:30 UTC
- I think it is a bug, not an enhancement.
- For opac/opac-topissues.pl I filed a separate bug (12136)
Comment 3 Jonathan Druart 2016-08-15 15:24:36 UTC
No longer valid, these 2 subs have been removed.