Summary: | Can't specify date for automatic resumption of suspended hold | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Hold requests | Assignee: | Owen Leonard <oleonard> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, gmcharlt, kyle, matted-34813 |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: | Bug 11702 - Can't specify date for automatic resumption of suspended hold |
Description
Owen Leonard
2014-02-06 17:08:50 UTC
Created attachment 25103 [details] [review] Bug 11702 - Can't specify date for automatic resumption of suspended hold When suspending an individual hold in the OPAC or staff client the date of resumption is saved as '000-00-00' no matter what dateformat setting you use. This is not true of performing a suspend-all action. This patch changes the date handling in C4::Reserves::ToggleSuspend to match that in C4::Reserves::SuspendAll. To test in the OPAC: 1. Turn on RequestOnOpac, AutoResumeSuspendedHolds, and SuspendHoldsOpac. 2. Log in to the OPAC and place a hold. 3. View the list of your existing holds (opac-user.pl). 4. Choose an individual hold to suspend, specify a suspend-until date, and submit. 5. When the page reloads the suspension should be saved with the correct resumption date. Test using all dateformat system preference options. Also test suspensions without resumption dates. To test in the staff client: 1. Turn on AutoResumeSuspendedHolds and SuspendHoldsIntranet. 2. Place a hold for a patron, or find an existing hold. 3. View the hold details page for that hold (/cgi-bin/koha/reserve/request.pl?biblionumber=XX). 4. Specify a suspend-until date for the hold and submit. 5. When the page reloads the hold should say "Unsuspend on" and show the correct resumption date. Test using all dateformat system preference options. Also test suspensions without resumption dates. Owen, I think we are trying to move away from using C4::Dates ... is that correct Galen et al? i tested without and with the patch(id=25103) and both worked as far as I could tell. I just queried the reserves table with mysql and saw the same results. But with Chris's comment #2, we should leave things be, until someone else can test to confirm my findings. I believe the QA followup I posted for bug 11694 fixes this issue. (In reply to Kyle M Hall from comment #4) > I believe the QA followup I posted for bug 11694 fixes this issue. It does for me, so I'll close this as a duplicate. *** This bug has been marked as a duplicate of bug 11694 *** |