Summary: | Use new DataTables include in suggestions template | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/suggestion/suggestion.pl | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 11721 - Use new DataTables include in suggestions template
Bug 11721 - Use new DataTables include in suggestions template [PASSED QA] Bug 11721 - Use new DataTables include in suggestions template |
Description
Owen Leonard
2014-02-07 19:46:03 UTC
Created attachment 25152 [details] [review] Bug 11721 - Use new DataTables include in suggestions template This patch modifies the template for the suggestions page to use the new DataTables include. This simplifies the inclusion of assets and updates to the latest DataTables version. Sorting is now configured to exclude articles when sorting the title column. To test, apply the patch and view the suggestions page (Acquisitions -> Suggestions). Sorting of suggestions should work correctly. Created attachment 25153 [details] [review] Bug 11721 - Use new DataTables include in suggestions template This patch modifies the template for the suggestions page to use the new DataTables include. This simplifies the inclusion of assets and updates to the latest DataTables version. Sorting is now configured to exclude articles when sorting the title column. To test, apply the patch and view the suggestions page (Acquisitions -> Suggestions). Sorting of suggestions should work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Funds and Status column are not sortable before and after the patch - it would be nice if they would be. Created attachment 25157 [details] [review] [PASSED QA] Bug 11721 - Use new DataTables include in suggestions template This patch modifies the template for the suggestions page to use the new DataTables include. This simplifies the inclusion of assets and updates to the latest DataTables version. Sorting is now configured to exclude articles when sorting the title column. To test, apply the patch and view the suggestions page (Acquisitions -> Suggestions). Sorting of suggestions should work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Note: the columsn fund and status are not sortable/searchable before and after applying the patch. Pushed to master. Thanks, Owen! Pushed to 3.14.x, will be in 3.14.07. |