Bug 11730

Summary: C4::Charset call C4::Context without use it
Product: Koha Reporter: Stéphane Delaune <stephane.delaune>
Component: Architecture, internals, and plumbingAssignee: Galen Charlton <gmcharlt>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, kyle
Version: 3.14   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: proposed patch
Bug 11730: C4-Charset call C4-Context without use it
Bug 11730: C4-Charset call C4-Context without use it

Description Stéphane Delaune 2014-02-10 09:48:56 UTC
C4::Charset call C4::Context without use it ; so when a script call SetMarcUnicodeFlag it returen : "Can't locate object method "preference" via package "C4::Context" (perhaps you forgot to load "C4::Context"?) at /home/gboisson/workspace/versions/community/C4/Charset.pm line 330".
Comment 1 Stéphane Delaune 2014-02-10 09:58:20 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-02-14 07:00:07 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-02-14 14:03:42 UTC
Created attachment 25266 [details] [review]
Bug 11730: C4-Charset call C4-Context without use it

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Galen Charlton 2014-02-18 21:53:40 UTC
Pushed to master.  Thanks, Stéphane!
Comment 5 Galen Charlton 2014-02-18 22:01:45 UTC
BTW, this bug inspired me to open bug 11790.
Comment 6 Fridolin Somers 2014-05-19 14:32:19 UTC
Pushed to 3.14.x, will be in 3.14.07
Comment 7 Kyle M Hall 2014-06-06 13:52:01 UTC
Pushed to 3.12.x will be in 3.12.13