Summary: | Use new DataTables include in quotes management template | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, sandboxes |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/tools/quotes.pl | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 11720 | ||
Attachments: |
Bug 11737 - Use new DataTables include in quotes management template
Bug 11737 - Use new DataTables include in quotes management template Bug 11737 - Use new DataTables include in quotes management template Bug 11737: (follow-up) fnReloadAjax.js is duplicated |
Description
Owen Leonard
2014-02-10 19:28:12 UTC
Created attachment 25182 [details] [review] Bug 11737 - Use new DataTables include in quotes management template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the quotes management page. To test you should have a multiple quotes in your database. Apply the patch and view the quotes manager page (tools/quotes.pl). Confirm that table sorting works correctly. Patch tested with a sandbox, by merlissia <manuelimel@gmail.com> Created attachment 25188 [details] [review] Bug 11737 - Use new DataTables include in quotes management template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the quotes management page. To test you should have a multiple quotes in your database. Apply the patch and view the quotes manager page (tools/quotes.pl). Confirm that table sorting works correctly. Signed-off-by: merlissia <manuelimel@gmail.com> Created attachment 25192 [details] [review] Bug 11737 - Use new DataTables include in quotes management template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the quotes management page. To test you should have a multiple quotes in your database. Apply the patch and view the quotes manager page (tools/quotes.pl). Confirm that table sorting works correctly. Signed-off-by: merlissia <manuelimel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 25193 [details] [review] Bug 11737: (follow-up) fnReloadAjax.js is duplicated the file dataTables.fnReloadAjax.js exists in the interface and themelang directories. It is only used in quotes.tt. So the unused one can be removed. test plan: git grep fnReloadAjax.js should return only 1 ref (quotes.tt) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master. Thanks, Owen! Pushed to 3.14.x, will be in 3.14.07. |