|
Description
Owen Leonard
2014-02-10 19:46:35 UTC
Created attachment 25183 [details] [review] Bug 11738 - Use new DataTables include in batch patron modification template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the batch patron modification template. This patch modifies the template so that date columns are sorted using the "title-string" filter, based on the unformatted date. The DataTables configuration has also been modified to account for varying structure based on the page state. Other minor edits: Corrected capitalization. To test, go Tools -> Batch patron modification and submit a list of patrons for modification. The resulting page should be correctly sorted. Date columns should sort correctly for all dateformat system pref settings. Submit a change to multiple borrowers. The results page should also be sorted correctly. Patch tested with a sandbox, by merlissia <manuelimel@gmail.com> Created attachment 25186 [details] [review] Bug 11738 - Use new DataTables include in batch patron modification template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the batch patron modification template. This patch modifies the template so that date columns are sorted using the "title-string" filter, based on the unformatted date. The DataTables configuration has also been modified to account for varying structure based on the page state. Other minor edits: Corrected capitalization. To test, go Tools -> Batch patron modification and submit a list of patrons for modification. The resulting page should be correctly sorted. Date columns should sort correctly for all dateformat system pref settings. Submit a change to multiple borrowers. The results page should also be sorted correctly. Signed-off-by: merlissia <manuelimel@gmail.com> Regression found. To reproduce: 1/ Link a patron attribute to a patron category. 2/ On the patrons mod tools, you should see (at the bottom): Attribute: [SELECT] [CHECKBOX] [INPUT] [New] This attribute will be only applied to the patron's category "CATEGORY_CODE" With the patch, I get: Attribute: [SELECT] [CHECKBOX] [New] This input and the message have disappeared. Marked as Failed QA. From IRC: oleonard: Joubu: I'm having trouble reproducing the problem you had with Bug 11738 oleonard: Joubu: Can you describe the patron attribute you're working with? Joubu: oleonard-away: In fact I get a JS error: "TypeError: m is undefined" Joubu: oleonard-away: It is caused by the dynamic rows added by borrower.patron_attributes Created attachment 25196 [details]
patron attr type screen
Created attachment 25197 [details]
batch mod patron screen - without patch
Created attachment 25198 [details]
batch mod patron screen - with patch
Created attachment 25200 [details] [review] Bug 11738 [Revised] Use new DataTables include in batch patron modification template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the batch patron modification template. This patch modifies the template so that date columns are sorted using the "title-string" filter, based on the unformatted date. The DataTables configuration has also been modified to account for varying structure based on the page state. Other minor edits: Corrected capitalization. To test, go Tools -> Batch patron modification and submit a list of patrons for modification. The resulting page should be correctly sorted. Date columns should sort correctly for all dateformat system pref settings. Test with extended patron attributes enabled. Test adding and removing varying numbers of attributes to patrons in your batch. Submit a change to multiple borrowers. The results page should also be sorted correctly. Revision: Corrected error caused by the variable number of columns in the table corresponding to varying numbers of patron attributes. Created attachment 25733 [details] [review] Bug 11738 [Revised] Use new DataTables include in batch patron modification template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the batch patron modification template. This patch modifies the template so that date columns are sorted using the "title-string" filter, based on the unformatted date. The DataTables configuration has also been modified to account for varying structure based on the page state. Other minor edits: Corrected capitalization. To test, go Tools -> Batch patron modification and submit a list of patrons for modification. The resulting page should be correctly sorted. Date columns should sort correctly for all dateformat system pref settings. Test with extended patron attributes enabled. Test adding and removing varying numbers of attributes to patrons in your batch. Submit a change to multiple borrowers. The results page should also be sorted correctly. Revision: Corrected error caused by the variable number of columns in the table corresponding to varying numbers of patron attributes. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 26379 [details] [review] [PASSED QA] Bug 11738 [Revised] Use new DataTables include in batch patron modification template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the batch patron modification template. This patch modifies the template so that date columns are sorted using the "title-string" filter, based on the unformatted date. The DataTables configuration has also been modified to account for varying structure based on the page state. Other minor edits: Corrected capitalization. To test, go Tools -> Batch patron modification and submit a list of patrons for modification. The resulting page should be correctly sorted. Date columns should sort correctly for all dateformat system pref settings. Test with extended patron attributes enabled. Test adding and removing varying numbers of attributes to patrons in your batch. Submit a change to multiple borrowers. The results page should also be sorted correctly. Revision: Corrected error caused by the variable number of columns in the table corresponding to varying numbers of patron attributes. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script, works as described. Pushed to master. Thanks, Owen! Pushed to 3.14.x, will be in 3.14.09 |