Summary: | Use new DataTables include in quotes upload template | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/tools/quotes-upload.pl | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 11720 | ||
Attachments: |
Bug 11740 - Use new DataTables include in quotes upload template
[SIGNED OFF] Bug 11740 - Use new DataTables include in quotes upload template Bug 11740 - Use new DataTables include in quotes upload template |
Description
Owen Leonard
2014-02-10 20:29:27 UTC
Created attachment 25195 [details] [review] Bug 11740 - Use new DataTables include in quotes upload template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the quotes upload page. To test you need a CSV file of quotes to upload ( "source","text" ). Go to Tools -> Quote editor and click the "Import quotes" button. Upload the CSV file and confirm that the table which previews the import results loads correctly. Sorting is not enabled, but pagination and searching should work. Created attachment 25400 [details] [review] [SIGNED OFF] Bug 11740 - Use new DataTables include in quotes upload template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the quotes upload page. To test you need a CSV file of quotes to upload ( "source","text" ). Go to Tools -> Quote editor and click the "Import quotes" button. Upload the CSV file and confirm that the table which previews the import results loads correctly. Sorting is not enabled, but pagination and searching should work. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 25438 [details] [review] Bug 11740 - Use new DataTables include in quotes upload template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the quotes upload page. To test you need a CSV file of quotes to upload ( "source","text" ). Go to Tools -> Quote editor and click the "Import quotes" button. Upload the CSV file and confirm that the table which previews the import results loads correctly. Sorting is not enabled, but pagination and searching should work. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> No regression found. Pushed to master. Thanks, Owen! Pushed to 3.14.x, will be in 3.14.07 |