Bug 11747

Summary: Default to logged in library for Overdue notice/status triggers
Product: Koha Reporter: Kyle M Hall <kyle>
Component: Architecture, internals, and plumbingAssignee: Kyle M Hall <kyle>
Status: CLOSED FIXED QA Contact: Jonathan Druart <jonathan.druart>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, jonathan.druart, katrin.fischer, m.de.rooy, mtompset, nick, nicole, sandboxes
Version: Main   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 11625    
Bug Blocks:    
Attachments: Bug 11747 - Default to logged in library for Overdue notice/status triggers
Bug 11747 - Default to logged in library for Overdue notice/status triggers
Bug 11747 - Default to logged in library for Overdue notice/status triggers
Bug 11747 [QA Followup] - Don't default to branch specific rules if only one branch exists
Bug 11747 - Default to logged in library for Overdue notice/status triggers
Bug 11747 [QA Followup] - Don't default to branch specific rules if only one branch exists
Bug 11747 [QA Followup 2] - Use system preference to control behavior
Bug 11747 [QA Followup 2] - Use system preference to control behavior
Bug 11747 - Add system preference DefaultToLoggedInLibraryOverdueTriggers
Bug 11747 - Implement DefaultToLoggedInLibraryOverdueTriggers
Bug 11747 - Implement DefaultToLoggedInLibraryOverdueTriggers
Bug 11747 [QA Followup] - Use system preference
Bug 11747 - Add system preference DefaultToLoggedInLibraryOverdueTriggers
Bug 11747 - Implement DefaultToLoggedInLibraryOverdueTriggers
Bug 11747 [QA Followup] - Use system preference

Description Kyle M Hall 2014-02-12 13:02:09 UTC
As with bug 11625, we should make the default selection for overdue notice/status triggers the logged in library.
Comment 1 Kyle M Hall 2014-02-12 13:07:05 UTC Comment hidden (obsolete)
Comment 2 Biblibre Sandboxes 2014-02-14 21:23:13 UTC
Patch tested with a sandbox, by Nick Clemens <nick@quecheelibrary.org>
Comment 3 Biblibre Sandboxes 2014-02-14 21:23:31 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2014-02-17 11:47:55 UTC Comment hidden (obsolete)
Comment 5 Galen Charlton 2014-02-19 17:38:37 UTC
Setting to in discussion for the same reason I set bug 11625 to in discussion.  I suggest that we use bug 11625 for all discussion, as whatever resolution occurs for that bug will, for the sake of consistency, should become the resolution for this one.
Comment 6 Kyle M Hall 2014-03-05 12:56:28 UTC Comment hidden (obsolete)
Comment 7 Katrin Fischer 2014-04-27 16:15:43 UTC
This depends on 11625 as we are still trying to agree how this should be working.
Comment 8 Kyle M Hall 2015-01-22 14:07:05 UTC Comment hidden (obsolete)
Comment 9 Kyle M Hall 2015-01-22 14:07:19 UTC Comment hidden (obsolete)
Comment 10 Kyle M Hall 2015-01-22 14:07:22 UTC Comment hidden (obsolete)
Comment 11 Kyle M Hall 2015-01-22 14:07:38 UTC
I don't think we'll ever get consensus on this, so I think the best way to move forward is to make this behavior controlled via system preferences.
Comment 12 Jonathan Druart 2015-02-11 11:35:22 UTC
This is blocked by the discussion on bug 11625.
Comment 13 Jonathan Druart 2015-04-17 08:35:00 UTC
It needs QA with bug 11625.
Comment 14 Jonathan Druart 2015-04-17 09:20:22 UTC
Bug 11625 does not apply, please also rebase this one.
Comment 15 Mark Tompsett 2015-04-18 03:24:45 UTC Comment hidden (obsolete)
Comment 16 Mark Tompsett 2015-04-18 03:26:51 UTC
Set to signed off from patch doesn't apply, since I believe that's where it should be.
Comment 17 Jonathan Druart 2015-04-20 10:57:40 UTC
Kyle,
I am almost ready to mark bug 11625 and this one as pass qa, but the updatedb entry is not clear.
Could you please add a clean patch for each pref (1 updatedb entry + sysprefs.sql + pref template)? This means 1 patch here for DefaultToLoggedInLibraryOverdueTriggers and 1 patch on bug 11625 for DefaultToLoggedInLibraryCircRules.
Comment 18 Kyle M Hall 2015-04-21 15:20:43 UTC Comment hidden (obsolete)
Comment 19 Kyle M Hall 2015-04-21 15:20:52 UTC Comment hidden (obsolete)
Comment 20 Kyle M Hall 2015-04-21 15:22:14 UTC Comment hidden (obsolete)
Comment 21 Jonathan Druart 2015-04-22 14:56:38 UTC
DefaultToLoggedInLibraryOverdueTriggers is never used in the code?
Comment 22 Kyle M Hall 2015-04-22 15:22:51 UTC Comment hidden (obsolete)
Comment 23 Marcel de Rooy 2015-08-20 08:02:21 UTC
Applying: Bug 11747 - Add system preference DefaultToLoggedInLibraryOverdueTriggers
/home/koha/testclone/.git/rebase-apply/patch:50: trailing whitespace.
            - When editing overdue notice/status triggers show the
fatal: sha1 information is lacking or useless (installer/data/mysql/sysprefs.sql).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Comment 24 Marcel de Rooy 2015-08-20 08:03:30 UTC
(In reply to Marcel de Rooy from comment #23)
> Applying: Bug 11747 - Add system preference
> DefaultToLoggedInLibraryOverdueTriggers
> /home/koha/testclone/.git/rebase-apply/patch:50: trailing whitespace.
>             - When editing overdue notice/status triggers show the
> fatal: sha1 information is lacking or useless
> (installer/data/mysql/sysprefs.sql).
> Repository lacks necessary blobs to fall back on 3-way merge.
> Cannot fall back to three-way merge.

oops, dependency
Comment 25 Jonathan Druart 2015-10-16 11:53:10 UTC
Created attachment 43499 [details] [review]
Bug 11747 - Add system preference DefaultToLoggedInLibraryOverdueTriggers

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Amended patch: INSERT IGNORE INTO + msg
Comment 26 Jonathan Druart 2015-10-16 11:53:13 UTC
Created attachment 43500 [details] [review]
Bug 11747 - Implement DefaultToLoggedInLibraryOverdueTriggers

This patch makes the default circ rules and notices/slips to edit
the logged in branch, if one is set.

Test Plan:
1) Apply this patch
2) Log into staff side, and set your library
3) Browse to Tools/Overdue notice/status triggers
4) Note the actions displayed are for your library
5) Select "All libraries"
6) Note the actions displayed are for "All libraries"

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 27 Jonathan Druart 2015-10-16 11:53:23 UTC
Created attachment 43501 [details] [review]
Bug 11747 [QA Followup] - Use system preference

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 28 Kyle M Hall 2015-12-30 11:49:26 UTC
Pushed to master!