Summary: | In OPAC, the serials details display the wrong periodicity | ||
---|---|---|---|
Product: | Koha | Reporter: | Blou <philippe.blouin> |
Component: | OPAC | Assignee: | Blou <philippe.blouin> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | francois.charbonnier, fridolin.somers, gmcharlt, jonathan.druart, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12108 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 11752 - wrong periodicity in OPAC details
Bug 11752 - wrong periodicity in OPAC details Bug 11752 - wrong periodicity in OPAC details |
Description
Blou
2014-02-12 16:43:17 UTC
Created attachment 25214 [details] [review] Bug 11752 - wrong periodicity in OPAC details This fixes bootstrap and prog by modifying the description displayed in the OPAC's detail of serials. TESTING to reproduce - create/find a serial with a 1/week periodicity (4 in the database) - Find it in the opac-detail.pl, click "more details" at the bottom - validate the string. Before the patch, it will say: "The current subscription began on 2013-12-06 and is issued every 3 weeks for 26 issues" The "every 3 weeks" is clearly wrong. In fact any periodicity chosen would display a wrong description, not matching the intranet. After the patch, the display is corrected. As a bonus, the "every 2 years" now has a description, where it had none before. Additional note to the testing procedure: - when in opac-detail.pl, you need to select the second tab, "Subscriptions" in order to see the "More details" link at the bottom. No wonder this very obvious bug was never spotted by anyone... Created attachment 25234 [details] [review] Bug 11752 - wrong periodicity in OPAC details This fixes bootstrap and prog by modifying the description displayed in the OPAC's detail of serials. TESTING to reproduce - create/find a serial with a 1/week periodicity (4 in the database) - Find it in the opac-detail.pl, click "more details" at the bottom - validate the string. Before the patch, it will say: "The current subscription began on 2013-12-06 and is issued every 3 weeks for 26 issues" The "every 3 weeks" is clearly wrong. In fact any periodicity chosen would display a wrong description, not matching the intranet. After the patch, the display is corrected. As a bonus, the "every 2 years" now has a description, where it had none before. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> It seems periodicityX should not be used anymore. You have to use the frequency description. Is the serial/serial-issues.pl a dead script (which refers to periodicityX too)? Created attachment 25280 [details] [review] Bug 11752 - wrong periodicity in OPAC details This fixes bootstrap and prog by modifying the description displayed in the OPAC's detail of serials. TESTING to reproduce - create/find a serial with a 1/week periodicity (4 in the database) - Find it in the opac-detail.pl, click "more details" at the bottom - validate the string. Before the patch, it will say: "The current subscription began on 2013-12-06 and is issued every 3 weeks for 26 issues" The "every 3 weeks" is clearly wrong. In fact any periodicity chosen would display a wrong description, not matching the intranet. After the patch, the display is corrected. As a bonus, the "every 2 years" now has a description, where it had none before. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Waiting for a response to the question/comment on comment 4 1) that description is in the database, making its translation ugly if I understand right. 2) this is a patch to a very obvious problem only one user ever noticed. We patched it while minimizing the effort needed (qa and dev). Rearchitecturing the way the information goes to the .tt does not fit the community need IMO (since no one ever made those mouse clicks, seemingly). I can see the benefit long term, if someone has something else to fix in that area. At this point, we don't. This patch fixes default values (from the installer or updatedb). If values are redefined, the display will be broken too. An easy way will be to retrieve frequencies.description, but it won't be translatable. Since it improves the current behavior, I agree to pass QA on it. (In reply to Blou from comment #7) > 1) that description is in the database, making its translation ugly if I > understand right. > 2) this is a patch to a very obvious problem only one user ever noticed. Only one of /your/ users, perhaps. > We > patched it while minimizing the effort needed (qa and dev). > Rearchitecturing the way the information goes to the .tt does not fit the > community need IMO (since no one ever made those mouse clicks, seemingly). It is perhaps something to be cautious about to make assertions about community needs. I will instead make a concrete point: your patch, while it is an improvement over the current state of affairs, does not account for the fact that nowadays users can readily create additional frequencies. Consequently, the OPAC serials details page *will* require more work. Pushed to master. Thanks, Philippe! See also bug 12108. Pushed to 3.14.x, will be in 3.14.10 Picked for 3.12.15! |