Summary: | Replace jQuery qTip plugin with Bootstrap tooltip on patron search form | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/members/members-home.pl | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 11753 - Replace jQuery qTip plugin with Bootstrap tooltip on patron search form
Bug 11753 - Replace jQuery qTip plugin with Bootstrap tooltip on patron search form Bug 11753 - Replace jQuery qTip plugin with Bootstrap tooltip on patron search form Bug 11753 - Replace jQuery qTip plugin with Bootstrap tooltip on patron search form |
Description
Owen Leonard
2014-02-12 17:19:14 UTC
Created attachment 25215 [details] [review] Bug 11753 - Replace jQuery qTip plugin with Bootstrap tooltip on patron search form The qTip plugin is out of date and incompatible with recent versions of jQuery. This patch replaces use of qTip on the patron search form with a Bootstrap tooltip implementation. To test, apply the patch and view /cgi-bin/koha/members/members-home.pl - Expand the patron search form by clicking the [+] - Change 'search fields' from 'Standard' to 'Date of birth' - A tooltip should appear giving details about the date format required - Change the 'search fields' to something else. The tooltip should not appear. Created attachment 25216 [details] [review] Bug 11753 - Replace jQuery qTip plugin with Bootstrap tooltip on patron search form The qTip plugin is out of date and incompatible with recent versions of jQuery. This patch replaces use of qTip on the patron search form with a Bootstrap tooltip implementation. To test, apply the patch and view /cgi-bin/koha/members/members-home.pl - Expand the patron search form by clicking the [+] - Change 'search fields' from 'Standard' to 'Date of birth' - A tooltip should appear giving details about the date format required - Change the 'search fields' to something else. The tooltip should not appear. Revision: Removed inclusion of qTip plugin from global header include. The other instance of qTip usage occurs on a page which loads the plugin separately. Created attachment 25309 [details] [review] Bug 11753 - Replace jQuery qTip plugin with Bootstrap tooltip on patron search form The qTip plugin is out of date and incompatible with recent versions of jQuery. This patch replaces use of qTip on the patron search form with a Bootstrap tooltip implementation. To test, apply the patch and view /cgi-bin/koha/members/members-home.pl - Expand the patron search form by clicking the [+] - Change 'search fields' from 'Standard' to 'Date of birth' - A tooltip should appear giving details about the date format required - Change the 'search fields' to something else. The tooltip should not appear. Revision: Removed inclusion of qTip plugin from global header include. The other instance of qTip usage occurs on a page which loads the plugin separately. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 25339 [details] [review] Bug 11753 - Replace jQuery qTip plugin with Bootstrap tooltip on patron search form The qTip plugin is out of date and incompatible with recent versions of jQuery. This patch replaces use of qTip on the patron search form with a Bootstrap tooltip implementation. To test, apply the patch and view /cgi-bin/koha/members/members-home.pl - Expand the patron search form by clicking the [+] - Change 'search fields' from 'Standard' to 'Date of birth' - A tooltip should appear giving details about the date format required - Change the 'search fields' to something else. The tooltip should not appear. Revision: Removed inclusion of qTip plugin from global header include. The other instance of qTip usage occurs on a page which loads the plugin separately. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master. Thanks, Owen! Pushed to 3.14.x, will be in 3.14.08 |