Bug 11772

Summary:	Show warning on About page:System information if no active currency is defined
Product:	Koha	Reporter:	Marc Véron <veron>
Component:	Staff interface	Assignee:	Marc Véron <veron>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low	CC:	chris, fridolin.somers, gmcharlt, jonathan.druart, kyle
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 11772 - Show warning on About page:System information if no active currency is defined Bug 11772 - Show warning on About page:System information if no active currency is defined Bug 11772 - Show warning on About page:System information if no active currency is defined

Description Marc Véron 2014-02-15 14:58:51 UTC

Having no active currency defined can lead to unexpected behaviour or crash (e.g. in SCO). There should be a general warning on About page (Warnings regarding the system configuration).
BTW: Bug 3970 introduced such warning on budget admin pages and currency admin page.

Comment 1 Marc Véron 2014-02-15 15:34:09 UTC Comment hidden (obsolete)

Created attachment 25303 [details] [review]
Bug 11772 - Show warning on About page:System information if no active currency is defined

This patch displays a warning on the About page when no active currency is defined.

Test plan:
1)
Make sure that no currency is defined as active
(Home › Administration › Currencies & Exchange rates › Currencies)
2)
Go to Home › About Koha > System information
Result: No warning issued.
3)
Applay patch and reload About page
Result: Warning issued.

Comment 2 Chris Cormack 2014-02-16 04:51:48 UTC Comment hidden (obsolete)

Created attachment 25307 [details] [review]
Bug 11772 - Show warning on About page:System information if no active currency is defined

This patch displays a warning on the About page when no active currency is defined.

Test plan:
1)
Make sure that no currency is defined as active
(Home › Administration › Currencies & Exchange rates › Currencies)
2)
Go to Home › About Koha > System information
Result: No warning issued.
3)
Applay patch and reload About page
Result: Warning issued.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Comment 3 Jonathan Druart 2014-02-17 11:34:03 UTC

Created attachment 25346 [details] [review]
Bug 11772 - Show warning on About page:System information if no active currency is defined

    Bug 11772 - Show warning on About page:System information if no active currency is defined

    This patch displays a warning on the About page when no active currency is defined.

    Test plan:
    1)
    Make sure that no currency is defined as active
    (Home › Administration › Currencies & Exchange rates › Currencies)
    2)
    Go to Home › About Koha > System information
    Result: No warning issued.
    3)
    Applay patch and reload About page
    Result: Warning issued.

    Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
    Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Comment 4 Galen Charlton 2014-02-18 21:01:51 UTC

Pushed to master, along with a follow-up that makes the warning be a link to the currency admin page.  Thanks, Marc!

Comment 5 Fridolin Somers 2014-06-03 12:37:01 UTC

Pushed to 3.14.x, will be in 3.14.08

Comment 6 Kyle M Hall (khall) 2014-06-06 13:58:18 UTC

Pushed to 3.12.x will be in 3.12.13