Summary: | Crash 'undefined value as a HASH' in sco-main.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | Self checkout | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P3 | CC: | chris, fridolin.somers, gmcharlt, jonathan.druart, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 11773 - Crash 'undefined value as a HASH' in sco-main.pl
Bug 11773 - Crash 'undefined value as a HASH' in sco-main.pl Bug 11773 - Crash 'undefined value as a HASH' in sco-main.pl |
Description
Marc Véron
2014-02-15 15:49:11 UTC
Created attachment 25304 [details] [review] Bug 11773 - Crash 'undefined value as a HASH' in sco-main.pl If no currency is defined as active and a patron with debts tries to check out in welf checkout moduel, sco-main.pl crashes with: Software error: Can't use an undefined value as a HASH reference at /usr/share/kohaclone/opac/sco/sco-main.pl line 190. This patch tests for active currency and simply does not display a currency symbol if appropriate. Test plan: 1) Make sure you have a patron with debts and no currency defined as active. (Home › Administration › Currencies & Exchange rates › Currencies ) 2) Go to Self checkout module and try to checkout an item to this patron Result: Crash wit error message "Can't use an undefined value as a HASH..." 3) Apply patch 4) Reload and try to checkout again Expected result: Message "You owe the library..." without currency symbol 5) Define a currency as active and try to checkout again Expected result: Message "You owe..." with currency symbol Created attachment 25311 [details] [review] Bug 11773 - Crash 'undefined value as a HASH' in sco-main.pl If no currency is defined as active and a patron with debts tries to check out in welf checkout moduel, sco-main.pl crashes with: Software error: Can't use an undefined value as a HASH reference at /usr/share/kohaclone/opac/sco/sco-main.pl line 190. This patch tests for active currency and simply does not display a currency symbol if appropriate. Test plan: 1) Make sure you have a patron with debts and no currency defined as active. (Home › Administration › Currencies & Exchange rates › Currencies ) 2) Go to Self checkout module and try to checkout an item to this patron Result: Crash wit error message "Can't use an undefined value as a HASH..." 3) Apply patch 4) Reload and try to checkout again Expected result: Message "You owe the library..." without currency symbol 5) Define a currency as active and try to checkout again Expected result: Message "You owe..." with currency symbol Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 25344 [details] [review] Bug 11773 - Crash 'undefined value as a HASH' in sco-main.pl Bug 11773 - Crash 'undefined value as a HASH' in sco-main.pl If no currency is defined as active and a patron with debts tries to check out in welf checkout moduel, sco-main.pl crashes with: Software error: Can't use an undefined value as a HASH reference at /usr/share/kohaclone/opac/sco/sco-main.pl line 190. This patch tests for active currency and simply does not display a currency symbol if appropriate. Test plan: 1) Make sure you have a patron with debts and no currency defined as active. (Home › Administration › Currencies & Exchange rates › Currencies ) 2) Go to Self checkout module and try to checkout an item to this patron Result: Crash wit error message "Can't use an undefined value as a HASH..." 3) Apply patch 4) Reload and try to checkout again Expected result: Message "You owe the library..." without currency symbol 5) Define a currency as active and try to checkout again Expected result: Message "You owe..." with currency symbol Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master. Thanks, Marc! Pushed to 3.14.x, will be in 3.14.07 Pushed to 3.12.x will be in 3.12.13 |