Summary: | Use validation plugin when creating new city | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | System Administration | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/admin/cities.pl?op=add_form | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 11791 - Use validation plugin when creating new city
Bug 11791 - Use validation plugin when creating new city Bug 11791 - Use validation plugin when creating new city |
Description
Owen Leonard
2014-02-19 16:35:09 UTC
Created attachment 25458 [details] [review] Bug 11791 - Use validation plugin when creating new city The page for adding a new city includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Cities -> New city. Try submitting the form without entering a city or zip code. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing city should also work correctly. Created attachment 25477 [details] [review] Bug 11791 - Use validation plugin when creating new city The page for adding a new city includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Cities -> New city. Try submitting the form without entering a city or zip code. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing city should also work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 25490 [details] [review] Bug 11791 - Use validation plugin when creating new city The page for adding a new city includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Cities -> New city. Try submitting the form without entering a city or zip code. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing city should also work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Note: This patch changes the behavior. Before the patch, only 1 out of city and zip was required. Now both are. Since the 2 inputs were marked as required, I think they should be. Pushed to master. Thanks, Owen! Pushed to 3.14.x, will be in 3.14.07 |