Summary: | Use validation plugin when creating new currency | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | System Administration | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/admin/currency.pl?op=add_form | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 11792 - Use validation plugin when creating new currency
Bug 11792 - Use validation plugin when creating new currency Bug 11792 - Use validation plugin when creating new currency |
Description
Owen Leonard
2014-02-19 16:59:24 UTC
Created attachment 25460 [details] [review] Bug 11792 - Use validation plugin when creating new currency The page for adding a new currency includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Currencies & Exchange rates -> New currency. Try submitting the form without entering a currency, rate, and/or symbol. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing currency should also work correctly. Created attachment 25476 [details] [review] Bug 11792 - Use validation plugin when creating new currency The page for adding a new currency includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Currencies & Exchange rates -> New currency. Try submitting the form without entering a currency, rate, and/or symbol. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing currency should also work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 25489 [details] [review] Bug 11792 - Use validation plugin when creating new currency The page for adding a new currency includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Currencies & Exchange rates -> New currency. Try submitting the form without entering a currency, rate, and/or symbol. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing currency should also work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master. Thanks, Owen! Pushed to 3.14.x, will be in 3.14.07 |