Summary: | Patron purchase suggestions page requires some corrections | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Patrons | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, kyle.m.hall |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/members/purchase-suggestions.pl?borrowernumber=X | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 9261 | ||
Bug Blocks: | |||
Attachments: |
Bug 11802 - Patron purchase suggestions page requires some corrections
[SIGNED-OFF] Bug 11802 - Patron purchase suggestions page requires some corrections Bug 11802 - Patron purchase suggestions page requires some corrections |
Description
Owen Leonard
2014-02-20 15:19:21 UTC
Created attachment 25511 [details] [review] Bug 11802 - Patron purchase suggestions page requires some corrections This patch corrects some errors with the staff client's patron purchase suggestions page (members/purchase-suggestions.pl). To test, apply the patch and make sure the patronimages system preference is enabled. - View the purchase suggestions page for a patron whose record has a patron image attached. The image should appear in the left-hand sidebar. - View the page for a patron who has submitted no purchase suggestions. The message should be styled correctly. - The toolbar on the page should look correct and work correctly. Created attachment 25985 [details] [review] [SIGNED-OFF] Bug 11802 - Patron purchase suggestions page requires some corrections This patch corrects some errors with the staff client's patron purchase suggestions page (members/purchase-suggestions.pl). To test, apply the patch and make sure the patronimages system preference is enabled. - View the purchase suggestions page for a patron whose record has a patron image attached. The image should appear in the left-hand sidebar. - View the page for a patron who has submitted no purchase suggestions. The message should be styled correctly. - The toolbar on the page should look correct and work correctly. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Created attachment 26001 [details] [review] Bug 11802 - Patron purchase suggestions page requires some corrections This patch corrects some errors with the staff client's patron purchase suggestions page (members/purchase-suggestions.pl). To test, apply the patch and make sure the patronimages system preference is enabled. - View the purchase suggestions page for a patron whose record has a patron image attached. The image should appear in the left-hand sidebar. - View the page for a patron who has submitted no purchase suggestions. The message should be styled correctly. - The toolbar on the page should look correct and work correctly. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> While testing this patch, I found a bug on uploading a picture for a patron, see bug 11917. Pushed to master. Thanks, Owen! Was released with 3.16.00. Depends on 9261, which is not in 3.14.x. |