Bug 11803

Summary: Consistent use of $dbh in _koha_modify_item
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: Architecture, internals, and plumbingAssignee: Marcel de Rooy <m.de.rooy>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: fridolin.somers, gmcharlt, jonathan.druart, kyle, veron
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 11803: Consistent use of $dbh in _koha_modify_item
[Signed-off] Bug 11803: Consistent use of $dbh in _koha_modify_item
Bug 11803: Consistent use of $dbh in _koha_modify_item

Description Marcel de Rooy 2014-02-20 18:47:32 UTC

    
Comment 1 Marcel de Rooy 2014-02-20 18:51:08 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2014-02-23 20:51:37 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2014-02-24 07:29:44 UTC
(In reply to Marc Véron from comment #2)
> Signed-off-by: Marc Véron <veron@veron.ch>

Thanks, Marc!
Comment 4 Jonathan Druart 2014-02-24 12:09:30 UTC
Created attachment 25576 [details] [review]
Bug 11803: Consistent use of $dbh in _koha_modify_item

This is just some code cleanup, no behavior change expected.
Also replacing errstr with err in testing the results. (See DBI.)

Test plan:
Modify an item and save it.

Followed test plan. No problems found.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Galen Charlton 2014-02-25 14:57:43 UTC
Pushed to master.  Thanks, Marcel!
Comment 6 Fridolin Somers 2014-05-21 09:10:52 UTC
Pushed to 3.14.x, will be in 3.14.07
Comment 7 Kyle M Hall 2014-06-06 13:56:08 UTC
Pushed to 3.12.x will be in 3.12.13