Bug 11805

Summary: Use validation plugin when creating new basket in Acquisitions
Product: Koha Reporter: Owen Leonard <oleonard>
Component: AcquisitionsAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, gmcharlt, katrin.fischer, veron
Version: master   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/acqui/basketheader.pl?booksellerid=X&op=add_form
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 11805 - Use validation plugin when creating new basket in Acquisitions
[Signed-off] Bug 11805 - Use validation plugin when creating new basket in Acquisitions
[PASSED QA] Bug 11805 - Use validation plugin when creating new basket in Acquisitions

Description Owen Leonard 2014-02-20 20:42:26 UTC
The new basket entry form in Acquisitions uses custom validation JavaScript which can be easily replaced with HTML5 validation attributes in conjunction with Koha's built-in validation plugin (http://jqueryvalidation.org/documentation/).
Comment 1 Owen Leonard 2014-02-20 20:46:22 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2014-02-23 21:49:14 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-02-23 22:12:55 UTC
Created attachment 25566 [details] [review]
[PASSED QA] Bug 11805 - Use validation plugin when creating new basket in Acquisitions

The page for adding a new basket in Acquisitions includes some custom
form validation JavaScript which can be removed in favor of HTML5
validation attributes and Koha's built-in validation plugin. This patch
does so.

To test, apply the patch and go to Acquisitions -> Choose a vendor ->
New basket. Try submitting the form without entering a basket name. This
should trigger a validation warning.

Submission of the form with valid data should work correctly. Editing an
existing basket should also work correctly.

Patch works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as expected, passes all tests and QA script.
Tried adding a new basket with/without basket name and editing
an existing basket editing/emptying the basket name.
Comment 4 Galen Charlton 2014-02-27 16:09:09 UTC
Pushed to master.  Thanks, Owen!
Comment 5 Fridolin Somers 2014-05-21 10:20:49 UTC
Pushed to 3.14.x, will be in 3.14.07