Summary: | Use validation plugin when creating new basket in Acquisitions | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Acquisitions | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/acqui/basketheader.pl?booksellerid=X&op=add_form | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 11805 - Use validation plugin when creating new basket in Acquisitions
[Signed-off] Bug 11805 - Use validation plugin when creating new basket in Acquisitions [PASSED QA] Bug 11805 - Use validation plugin when creating new basket in Acquisitions |
Description
Owen Leonard
2014-02-20 20:42:26 UTC
Created attachment 25524 [details] [review] Bug 11805 - Use validation plugin when creating new basket in Acquisitions The page for adding a new basket in Acquisitions includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Acquisitions -> Choose a vendor -> New basket. Try submitting the form without entering a basket name. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing basket should also work correctly. Created attachment 25562 [details] [review] [Signed-off] Bug 11805 - Use validation plugin when creating new basket in Acquisitions The page for adding a new basket in Acquisitions includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Acquisitions -> Choose a vendor -> New basket. Try submitting the form without entering a basket name. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing basket should also work correctly. Patch works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 25566 [details] [review] [PASSED QA] Bug 11805 - Use validation plugin when creating new basket in Acquisitions The page for adding a new basket in Acquisitions includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Acquisitions -> Choose a vendor -> New basket. Try submitting the form without entering a basket name. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing basket should also work correctly. Patch works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as expected, passes all tests and QA script. Tried adding a new basket with/without basket name and editing an existing basket editing/emptying the basket name. Pushed to master. Thanks, Owen! Pushed to 3.14.x, will be in 3.14.07 |