| Summary: | OPAC patron details form shouldn't show 'Clear date' if field is required | ||
|---|---|---|---|
| Product: | Koha | Reporter: | paxed <pasi.kallinen> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kyle, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 11809 - OPAC patron details form shouldn't show 'Clear date' if field is required
[Signed-off] Bug 11809 - OPAC patron details form shouldn't show 'Clear date' if field is required [PASSED QA] Bug 11809 - OPAC patron details form shouldn't show 'Clear date' if field is required |
||
|
Description
paxed
2014-02-21 06:59:57 UTC
Created attachment 25544 [details] [review] Bug 11809 - OPAC patron details form shouldn't show 'Clear date' if field is required On the OPAC's patron details form, if the date of birth field is required we shouldn't offer the user a "clear date." This patch removes the "clear date" link if the field is required. To test, configure the BorrowerMandatoryField system preference to require dateofbirth. Enable the OPACPatronDetails system preference and log in to the OPAC. View the "personal details" form and confirm that there is no "clear date" link next to the required date of birth field. Remove dateofbirth from the BorrowerMandatoryField system preference and re-test. The "clear date" link should appear. Test in both prog and Bootstrap themes. Created attachment 25558 [details] [review] [Signed-off] Bug 11809 - OPAC patron details form shouldn't show 'Clear date' if field is required On the OPAC's patron details form, if the date of birth field is required we shouldn't offer the user a "clear date." This patch removes the "clear date" link if the field is required. To test, configure the BorrowerMandatoryField system preference to require dateofbirth. Enable the OPACPatronDetails system preference and log in to the OPAC. View the "personal details" form and confirm that there is no "clear date" link next to the required date of birth field. Remove dateofbirth from the BorrowerMandatoryField system preference and re-test. The "clear date" link should appear. Test in both prog and Bootstrap themes. I tested with prog and bootstrap themes, adding/removing field 'dateofbirth' in sys pref PatronSelfRegistrationBorrowerMandatoryField. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 25563 [details] [review] [PASSED QA] Bug 11809 - OPAC patron details form shouldn't show 'Clear date' if field is required On the OPAC's patron details form, if the date of birth field is required we shouldn't offer the user a "clear date." This patch removes the "clear date" link if the field is required. To test, configure the BorrowerMandatoryField system preference to require dateofbirth. Enable the OPACPatronDetails system preference and log in to the OPAC. View the "personal details" form and confirm that there is no "clear date" link next to the required date of birth field. Remove dateofbirth from the BorrowerMandatoryField system preference and re-test. The "clear date" link should appear. Test in both prog and Bootstrap themes. I tested with prog and bootstrap themes, adding/removing field 'dateofbirth' in sys pref PatronSelfRegistrationBorrowerMandatoryField. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as expected, passes all tests and QA script. Pushed to master. Thanks, Owen! Pushed to 3.14.x, will be in 3.14.08 Pushed to 3.12.x will be in 3.12.13 |