Summary: | Input fields in OPAC suggestion form are a bit short (Bootstrap) | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | tomascohen, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 11810 - Input fields in OPAC suggestion form are a bit short (Bootstrap)
Bug 11810 - Input fields in OPAC suggestion form are a bit short (Bootstrap) [PASSED QA] Bug 11810 - Input fields in OPAC suggestion form are a bit short (Bootstrap) |
Description
Katrin Fischer
2014-02-21 12:00:31 UTC
Created attachment 29333 [details] [review] Bug 11810 - Input fields in OPAC suggestion form are a bit short (Bootstrap) The default Bootstrap input size (absent any specific input size or class) is too short for the suggestion form. This patch adds a Bootstrap class to fields which need more room and adjusts the OPAC CSS to allow for better handling of input width at lower screen widths. To test apply the patch and clear your browser cache if necessary. Open the "new suggestion" form in the OPAC and confirm that the entry fields for title, author, publisher, and collection title are sized well. Adjust the width of your browser window up and down to confirm that the field sizes adjust well at various screen widths. Created attachment 29348 [details] [review] Bug 11810 - Input fields in OPAC suggestion form are a bit short (Bootstrap) The default Bootstrap input size (absent any specific input size or class) is too short for the suggestion form. This patch adds a Bootstrap class to fields which need more room and adjusts the OPAC CSS to allow for better handling of input width at lower screen widths. To test apply the patch and clear your browser cache if necessary. Open the "new suggestion" form in the OPAC and confirm that the entry fields for title, author, publisher, and collection title are sized well. Adjust the width of your browser window up and down to confirm that the field sizes adjust well at various screen widths. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 29350 [details] [review] [PASSED QA] Bug 11810 - Input fields in OPAC suggestion form are a bit short (Bootstrap) The default Bootstrap input size (absent any specific input size or class) is too short for the suggestion form. This patch adds a Bootstrap class to fields which need more room and adjusts the OPAC CSS to allow for better handling of input width at lower screen widths. To test apply the patch and clear your browser cache if necessary. Open the "new suggestion" form in the OPAC and confirm that the entry fields for title, author, publisher, and collection title are sized well. Adjust the width of your browser window up and down to confirm that the field sizes adjust well at various screen widths. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, no problems found. Pushed to master, along with a followup of the resulting regenerated opac.css for bootstrap. Thanks Owen! FTR: on recent versions (1.7.3) of LESS, the '-x' switch should be used instead of '--yui-compress' (which has been deprecated. |