Summary: | Untranslatable "Cancel Rating" in jQuery rating plugin | ||
---|---|---|---|
Product: | Koha | Reporter: | paxed <pasi.kallinen> |
Component: | I18N/L10N | Assignee: | paxed <pasi.kallinen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | f.demians, nick, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Allow translating "Cancel Rating", and use string formatting for couple other strings
Allow translating "Cancel Rating", and use string formatting for couple other strings Bug 11827: Untranslatable "Cancel Rating" in jQuery rating plugin Bug 11827: Untranslatable "Cancel Rating" in jQuery rating plugin Bug 11827: (follow-up) Use double quote instead of simple-quote |
Description
paxed
2014-02-24 10:49:08 UTC
Created attachment 71019 [details] [review] Allow translating "Cancel Rating", and use string formatting for couple other strings This looks fine, and works correctly. I request one small fix: Our capitalization rules (https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML4:_Upper_and_lower_cases_in_strings) say that only the first letter of the first word should be capitalized. I realize that the patch matches what the plugin has in its code, but we should follow the rules if we're adding it to our template. Created attachment 71102 [details] [review] Allow translating "Cancel Rating", and use string formatting for couple other strings - Make the "Cancel rating" text translatable (and change capitalization to conform to Koha coding guidelines) - Improve the two other messages to use formatted strings instead of concatenation. - Use the exact same text for the "your rating" text, so it only appears once in the po-file. Test plan: 1. See that the "Cancel rating" -text doesn't appear in po/xx-YY-opac-bootstrap.po 2. Note how there's two versions of the your rating -text ("your rating: %s, " and "your rating:") in the po-file 3. Apply patch 4. Update the xx-YY translation 5. Check the po-file. It should now contain the "Cancel rating" and a single "your rating: %s, " 6. Translate those texts, and update & install the language. 7. Go to the OPAC detail page of a biblio, and check the rating texts. 8. Hovering over the rating minus -sign should show the translated "Cancel rating" 9. Check that the text after the stars is correct with and without your rating Created attachment 71111 [details] [review] Bug 11827: Untranslatable "Cancel Rating" in jQuery rating plugin - Make the "Cancel rating" text translatable (and change capitalization to conform to Koha coding guidelines) - Improve the two other messages to use formatted strings instead of concatenation. - Use the exact same text for the "your rating" text, so it only appears once in the po-file. Test plan: 1. See that the "Cancel rating" -text doesn't appear in po/xx-YY-opac-bootstrap.po 2. Note how there's two versions of the your rating -text ("your rating: %s, " and "your rating:") in the po-file 3. Apply patch 4. Update the xx-YY translation 5. Check the po-file. It should now contain the "Cancel rating" and a single "your rating: %s, " 6. Translate those texts, and update & install the language. 7. Go to the OPAC detail page of a biblio, and check the rating texts. 8. Hovering over the rating minus -sign should show the translated "Cancel rating" 9. Check that the text after the stars is correct with and without your rating Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 71172 [details] [review] Bug 11827: Untranslatable "Cancel Rating" in jQuery rating plugin - Make the "Cancel rating" text translatable (and change capitalization to conform to Koha coding guidelines) - Improve the two other messages to use formatted strings instead of concatenation. - Use the exact same text for the "your rating" text, so it only appears once in the po-file. Test plan: 1. See that the "Cancel rating" -text doesn't appear in po/xx-YY-opac-bootstrap.po 2. Note how there's two versions of the your rating -text ("your rating: %s, " and "your rating:") in the po-file 3. Apply patch 4. Update the xx-YY translation 5. Check the po-file. It should now contain the "Cancel rating" and a single "your rating: %s, " 6. Translate those texts, and update & install the language. 7. Go to the OPAC detail page of a biblio, and check the rating texts. 8. Hovering over the rating minus -sign should show the translated "Cancel rating" 9. Check that the text after the stars is correct with and without your rating Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 71225 [details] [review] Bug 11827: (follow-up) Use double quote instead of simple-quote Pushed to master for 18.05, thanks to everybody involved! Awesome work all, pushed to stable for 17.11.03 |