Summary: | Cannot clear date of birth via OPAC patron update | ||
---|---|---|---|
Product: | Koha | Reporter: | Galen Charlton <gmcharlt> |
Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | jonathan.druart, katrin.fischer, lucas, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.05.00, 18.11.06
|
|
Bug Depends on: | |||
Bug Blocks: | 23151 | ||
Attachments: |
Bug 11853: Add tests
Bug 11853: Allow to clear the date of birth at the OPAC Bug 11853: Allow to clear the date of birth at the OPAC Bug 11853: Add tests Bug 11853: Allow to clear the date of birth at the OPAC Bug 11853: Add tests [18.05.x] Bug 11853: Add tests |
Description
Galen Charlton
2014-02-26 17:44:50 UTC
Confirmed, the bug is still there. Date of birth is a quite delicate information to store considering data privacy. I am upping severity a bit. It looks like the change on dateofbirth is recorded as 'NULL' in the table borrower_modifications, which is interpreted as 'no change'. Other strings that are emptied out are recorded as '' (empty string) and trigger the change. I am not quite sure how to resolve this. Upping severity (OPAC, GDPR, patron privacy...) Created attachment 89480 [details] [review] Bug 11853: Add tests Created attachment 89481 [details] [review] Bug 11853: Allow to clear the date of birth at the OPAC A patron is not able to clear their date of birth. When cleared tt is set to NULL in DB which means, for the patron's modifications feature, that nothing has been changed. Test plan: 0/ Do not apply the patch 1/ Edit your personal details at the OPAC 2/ Add a date of birth 3/ On the staff interface, approve the modification request => OK it is updated 4/ Edit your personal details and clear the date of birth 5/ On the staff interface => KO the table display is wrong, nothing is marked has changed 6/ Approve the modification requiest => KO it has not been cleared 7/ Apply the patch and repeat 1 to 6 and confirm that the behaviors are now correct. Created attachment 89483 [details] [review] Bug 11853: Allow to clear the date of birth at the OPAC A patron is not able to clear their date of birth. When cleared tt is set to NULL in DB which means, for the patron's modifications feature, that nothing has been changed. Test plan: 0/ Do not apply the patch 1/ Edit your personal details at the OPAC 2/ Add a date of birth 3/ On the staff interface, approve the modification request => OK it is updated 4/ Edit your personal details and clear the date of birth 5/ On the staff interface => KO the table display is wrong, nothing is marked has changed 6/ Approve the modification requiest => KO it has not been cleared 7/ Apply the patch and repeat 1 to 6 and confirm that the behaviors are now correct. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Created attachment 89484 [details] [review] Bug 11853: Add tests Signed-off-by: Liz Rea <wizzyrea@gmail.com> Created attachment 89580 [details] [review] Bug 11853: Allow to clear the date of birth at the OPAC A patron is not able to clear their date of birth. When cleared tt is set to NULL in DB which means, for the patron's modifications feature, that nothing has been changed. Test plan: 0/ Do not apply the patch 1/ Edit your personal details at the OPAC 2/ Add a date of birth 3/ On the staff interface, approve the modification request => OK it is updated 4/ Edit your personal details and clear the date of birth 5/ On the staff interface => KO the table display is wrong, nothing is marked has changed 6/ Approve the modification requiest => KO it has not been cleared 7/ Apply the patch and repeat 1 to 6 and confirm that the behaviors are now correct. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 89581 [details] [review] Bug 11853: Add tests Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Thx a lot for the fix, this one was giving me a headache! Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.06 having problems rebasing for 18.05.x, if its need please provide a rebase Created attachment 90321 [details] [review] [18.05.x] Bug 11853: Add tests Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> |