| Summary: | Staff side course reserves too restrictive | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Course reserves | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 11713 | ||
| Attachments: |
Bug 11866 - Staff side course reserves too restrictive
[SIGNED-OFF] Bug 11866 - Staff side course reserves too restrictive Bug 11866 [Follow-up] Staff side course reserves too restrictive [SIGNED-OFF] Bug 11866 [Follow-up] Staff side course reserves too restrictive Bug 11866 - Staff side course reserves too restrictive Bug 11866: FIX ergonomic issue |
||
|
Description
Kyle M Hall (khall)
2014-02-27 13:55:13 UTC
Created attachment 25699 [details] [review] Bug 11866 - Staff side course reserves too restrictive A librarian with no course reserves permissions cannot view course reserves from the staff intranet, yet can from the OPAC. This doesn't make much sense. Librarians should not require any course reserves permissions to view courses and reserves from the staff intranet. Test Plan: 1) Log into staff intranet as a librarian with no course reserves permissions 2) Note you cannot view course reserves 3) Apply this patch 4) Note you can now view course reserves 5) Verify you cannot modify courses or course reserves Kyle I think the change to header.inc should swap the permissions check for a check of the UseCourseReserves system preference. If that pref is turned off, don't show the link. Created attachment 25863 [details] [review] [SIGNED-OFF] Bug 11866 - Staff side course reserves too restrictive A librarian with no course reserves permissions cannot view course reserves from the staff intranet, yet can from the OPAC. This doesn't make much sense. Librarians should not require any course reserves permissions to view courses and reserves from the staff intranet. Test Plan: 1) Log into staff intranet as a librarian with no course reserves permissions 2) Note you cannot view course reserves 3) Apply this patch 4) Note you can now view course reserves 5) Verify you cannot modify courses or course reserves Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 25864 [details] [review] Bug 11866 [Follow-up] Staff side course reserves too restrictive This follow-up patch adds a check for the "UseCourseReserves" system preference to the display of the Course reserves menu item in the header. To test, view the "More" menu with the "UseCourseReserves" system preference on and off. The menu item should appear and disappear accordingly. Created attachment 25948 [details] [review] [SIGNED-OFF] Bug 11866 [Follow-up] Staff side course reserves too restrictive This follow-up patch adds a check for the "UseCourseReserves" system preference to the display of the Course reserves menu item in the header. To test, view the "More" menu with the "UseCourseReserves" system preference on and off. The menu item should appear and disappear accordingly. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 26010 [details] [review] Bug 11866 - Staff side course reserves too restrictive A librarian with no course reserves permissions cannot view course reserves from the staff intranet, yet can from the OPAC. This doesn't make much sense. Librarians should not require any course reserves permissions to view courses and reserves from the staff intranet. Test Plan: 1) Log into staff intranet as a librarian with no course reserves permissions 2) Note you cannot view course reserves 3) Apply this patch 4) Note you can now view course reserves 5) Verify you cannot modify courses or course reserves Signed-off-by: Owen Leonard <oleonard@myacpl.org> Bug 11866 [Follow-up] Staff side course reserves too restrictive This follow-up patch adds a check for the "UseCourseReserves" system preference to the display of the Course reserves menu item in the header. To test, view the "More" menu with the "UseCourseReserves" system preference on and off. The menu item should appear and disappear accordingly. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 26011 [details] [review] Bug 11866: FIX ergonomic issue If a user does not have course_reserve permission, a an empty toolbar is displayed. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> I squashed 2 first patches for a better readability and submit a small fix for an ergonomic issue. (In reply to Jonathan Druart from comment #7) > If a user does not have course_reserve permission, a an empty toolbar is > displayed. I think I fixed this in my patch for Bug 11713 Pushed to master, along with a follow-up that ensures that a user must have at least the 'catalogue' permission to view the staff-side page. Thanks, Kyle! Pushed to 3.14.x, will be in 3.14.07 *** Bug 12248 has been marked as a duplicate of this bug. *** |