Summary: | Multi transport types: disable sms and phone if not in use | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Tools | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, olli-antti.kivilahti |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 9016 | ||
Bug Blocks: | |||
Attachments: |
Bug 11868: MTT: disable sms and phone if not in use
Bug 11868: MTT: disable sms and phone if not in use Bug 11868: MTT: disable sms and phone if not in use [PASSED QA] Bug 11868: MTT: disable sms and phone if not in use |
Description
Jonathan Druart
2014-02-27 14:02:40 UTC
Created attachment 25701 [details] [review] Bug 11868: MTT: disable sms and phone if not in use On both pages "Notices and slips" and "Overdue rules", it would be great to disable sms and phone if there are not in use. Test plan: 1/ Edit a notice 2/ Enable/disable the SMSSendDriver pref and verify the sms block is enabled/disabled. 3/ Enable/disable the TalkingTechItivaPhoneNotification pref and verify the phone block is enabled/disabled. 4/ Go on tools/overdues.pl 5/ Enable/disable the SMSSendDriver pref and verify the sms checkboxes are enabled/disabled. 6/ Enable/disable the TalkingTechItivaPhoneNotification pref and verify the phone checkboxes are enabled/disabled. No merge issues here, which is great! For me the sms and phone checkboxes are disabled even if I have the SMSSendDriver = InaFinland::Driver && TalkingTechItivaPhoneNotification = 1. Sometimes these systempreferences are not updated in the DB, but I checked for that as well. I activated both and it shows in DB as well. Still sms and phone remain disabled. Created attachment 25763 [details] [review] Bug 11868: MTT: disable sms and phone if not in use On both pages "Notices and slips" and "Overdue rules", it would be great to disable sms and phone if there are not in use. Test plan: 1/ Edit a notice 2/ Enable/disable the SMSSendDriver pref and verify the sms block is enabled/disabled. 3/ Enable/disable the TalkingTechItivaPhoneNotification pref and verify the phone block is enabled/disabled. 4/ Go on tools/overdues.pl 5/ Enable/disable the SMSSendDriver pref and verify the sms checkboxes are enabled/disabled. 6/ Enable/disable the TalkingTechItivaPhoneNotification pref and verify the phone checkboxes are enabled/disabled. I forgot the [% USE Koha %]. It should be fixed now. Created attachment 25764 [details] [review] Bug 11868: MTT: disable sms and phone if not in use On both pages "Notices and slips" and "Overdue rules", it would be great to disable sms and phone if there are not in use. Test plan: 1/ Edit a notice 2/ Enable/disable the SMSSendDriver pref and verify the sms block is enabled/disabled. 3/ Enable/disable the TalkingTechItivaPhoneNotification pref and verify the phone block is enabled/disabled. 4/ Go on tools/overdues.pl 5/ Enable/disable the SMSSendDriver pref and verify the sms checkboxes are enabled/disabled. 6/ Enable/disable the TalkingTechItivaPhoneNotification pref and verify the phone checkboxes are enabled/disabled. Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --------------- Testing report: --------------- Followed the test plan. Reviewed the code modifications. Feature works as expected. Created attachment 27289 [details] [review] [PASSED QA] Bug 11868: MTT: disable sms and phone if not in use On both pages "Notices and slips" and "Overdue rules", it would be great to disable sms and phone if there are not in use. Test plan: 1/ Edit a notice 2/ Enable/disable the SMSSendDriver pref and verify the sms block is enabled/disabled. 3/ Enable/disable the TalkingTechItivaPhoneNotification pref and verify the phone block is enabled/disabled. 4/ Go on tools/overdues.pl 5/ Enable/disable the SMSSendDriver pref and verify the sms checkboxes are enabled/disabled. 6/ Enable/disable the TalkingTechItivaPhoneNotification pref and verify the phone checkboxes are enabled/disabled. Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --------------- Testing report: --------------- Followed the test plan. Reviewed the code modifications. Feature works as expected. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master. Thanks, Jonathan! |