Bug 11868

Summary: Multi transport types: disable sms and phone if not in use
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: ToolsAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, olli-antti.kivilahti
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 9016    
Bug Blocks:    
Attachments: Bug 11868: MTT: disable sms and phone if not in use
Bug 11868: MTT: disable sms and phone if not in use
Bug 11868: MTT: disable sms and phone if not in use
[PASSED QA] Bug 11868: MTT: disable sms and phone if not in use

Description Jonathan Druart 2014-02-27 14:02:40 UTC
On both pages "Notices and slips" and "Overdue rules", it would be great to disable sms and phone if there are not in use.

What about the "feed" transport type? Is it in use?
Comment 1 Jonathan Druart 2014-02-27 14:09:58 UTC Comment hidden (obsolete)
Comment 2 Olli-Antti Kivilahti 2014-03-03 13:02:27 UTC
No merge issues here, which is great!

For me the sms and phone checkboxes are disabled even if I have the SMSSendDriver = InaFinland::Driver  &&   TalkingTechItivaPhoneNotification = 1.
Sometimes these systempreferences are not updated in the DB, but I checked for that as well. I activated both and it shows in DB as well. Still sms and phone remain disabled.
Comment 3 Jonathan Druart 2014-03-03 13:38:30 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2014-03-03 13:39:10 UTC
I forgot the [% USE Koha %]. It should be fixed now.
Comment 5 Olli-Antti Kivilahti 2014-03-03 13:44:17 UTC Comment hidden (obsolete)
Comment 6 Kyle M Hall (khall) 2014-04-18 13:33:45 UTC
Created attachment 27289 [details] [review]
[PASSED QA] Bug 11868: MTT: disable sms and phone if not in use

On both pages "Notices and slips" and "Overdue rules", it would be great
to disable sms and phone if there are not in use.

Test plan:
1/ Edit a notice
2/ Enable/disable the SMSSendDriver pref and verify the sms block is
enabled/disabled.
3/ Enable/disable the TalkingTechItivaPhoneNotification pref and verify
the phone block is enabled/disabled.

4/ Go on tools/overdues.pl
5/ Enable/disable the SMSSendDriver pref and verify the sms checkboxes
are enabled/disabled.
6/ Enable/disable the TalkingTechItivaPhoneNotification pref and verify
the phone checkboxes are enabled/disabled.

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi>

---------------
Testing report:
---------------
Followed the test plan. Reviewed the code modifications.
Feature works as expected.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Galen Charlton 2014-05-02 21:20:17 UTC
Pushed to master.  Thanks, Jonathan!