| Summary: | Add additional order fields and basket group fields to order search result list | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
| Component: | Acquisitions | Assignee: | Julian Maurice <julian.maurice> |
| Status: | Patch doesn't apply --- | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | abl, fridolin.somers, indradg, jonathan.druart, jose-mario.monteiro-santos, marjorie.barry-vila, michaela.sieber, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20892 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 11708, 11844 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 11870: Add more informations to histsearch.pl results
Bug 11870: Add more informations to histsearch.pl results Bug 11870: Add more informations to histsearch.pl results |
||
|
Description
Julian Maurice
2014-02-28 12:48:54 UTC
Created attachment 25717 [details] [review] Bug 11870: Add more informations to histsearch.pl results - Basket group closed date and delivery place (in basketgroup column) - Additional order fields (one column for each additional field) Depends on bugs 11844 and 11708 Test plan: 1/ Add some additional fields (see bug 11844) 2/ Create some order lines in different baskets (filling additional fields with data) 3/ Attach some of these baskets to basketgroups 4/ Fill basketgroups deliveryplace (using free delivery place textarea or the dropdown list) 5/ Close some of these basketgroups 6/ Go to advanced order line search and run a search. 7/ You should see basketgroup closed date and delivery place in basketgroup column, and one additional column for each additional field. Julian, there is a "searchable" flag in the additional_fields table, I think you should use it to know if we want to display fields in the search form. (In reply to Jonathan Druart from comment #3) > Julian, there is a "searchable" flag in the additional_fields table, I think > you should use it to know if we want to display fields in the search form. Does this comment change whether this bug is ready for signoff? (In reply to Owen Leonard from comment #4) > (In reply to Jonathan Druart from comment #3) > > Julian, there is a "searchable" flag in the additional_fields table, I think > > you should use it to know if we want to display fields in the search form. > > Does this comment change whether this bug is ready for signoff? I don't think so, as the patch only display more data in results. It doesn't change the form. Jonathan, are you suggesting we *have to* display these searchable fields in the form ? (In reply to Julian Maurice from comment #5) > (In reply to Owen Leonard from comment #4) > > (In reply to Jonathan Druart from comment #3) > > > Julian, there is a "searchable" flag in the additional_fields table, I think > > > you should use it to know if we want to display fields in the search form. > > > > Does this comment change whether this bug is ready for signoff? > > I don't think so, as the patch only display more data in results. It doesn't > change the form. > Jonathan, are you suggesting we *have to* display these searchable fields in > the form ? The current behavior (for subscriptions) is to not display fields which are not searchable. I think I agree with Jonathan here: In order to have some consistency I'd add a searchable flag in the field configuration and use that to determine if the field shows up in the result list and if it's searchable. This would copy the behaviour from the additional subscription fields. Needs rebase on master. Especially method C4::Koha::GetAuthValCodeFromField has been removed by Bug 17249 Created attachment 75355 [details] [review] Bug 11870: Add more informations to histsearch.pl results - Basket group closed date and delivery place (in basketgroup column) - Additional order fields (one column for each additional field) Depends on bugs 11844 and 11708 Rebased on master Created attachment 75356 [details] [review] Bug 11870: Add more informations to histsearch.pl results - Basket group closed date and delivery place (in basketgroup column) - Additional order fields (one column for each additional field) Depends on bugs 11844 and 11708 Patch failed to apply Applying: Bug 11870: Add more informations to histsearch.pl results fatal: sha1 information is lacking or useless (C4/Acquisition.pm). error: could not build fake ancestor Patch failed at 0001 Bug 11870: Add more informations to histsearch.pl results There are dependencies on this bug not applying, I think this might be the issue (bug 11708 and bug 11844) I believe if the order lines could and the other fields could be split into separate patches, we could make this move again with bug 11844 now pushed. |