Bug 11922

Summary: Add SHOW_BCODE patron attribute for Norwegian web installer
Product: Koha Reporter: Magnus Enger <magnus>
Component: Installation and upgrade (web-based installer)Assignee: Jasmine Amohia <jasmineamohia.student>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: david, fridolin.somers, gmcharlt, jasmineamohia.student, jonathan.druart, katrin.fischer, lucas, martin.renvoize, nick
Version: MainKeywords: Academy
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18348
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 11922: Added SHOW_BCIDE patron attribute for Norwegian web installer
Bug 11922: Added SHOW_BCIDE patron attribute for Norwegian web installer
Bug 11922: Added SHOW_BCODE patron attribute for Norwegian web installer
Bug 11922: Add SHOW_BCODE patron attribute for Norwegian web installer

Description Magnus Enger 2014-03-11 09:22:32 UTC
The Norwegian web installer needs nb-NO/optional/patron_atributes.sql and .txt to stay in sync with other languages.
Comment 1 Jasmine Amohia 2019-01-17 02:41:44 UTC
Created attachment 84117 [details] [review]
Bug 11922: Added SHOW_BCIDE patron attribute for Norwegian web installer

Test plan:
1. Notice that /patron_attributes.sql and /patron_attributes.txt can be
located in 2-Valgfritt
2. Confirm that the SHOW_BCODE patron attribute in the English web
installers .sql and .txt file is also in the Norwegian web installers
.sql and .txt file
Comment 2 David Nind 2019-01-17 20:20:14 UTC
Created attachment 84157 [details] [review]
Bug 11922: Added SHOW_BCIDE patron attribute for Norwegian web installer

Test plan:
1. Notice that /patron_attributes.sql and /patron_attributes.txt can be
located in 2-Valgfritt
2. Confirm that the SHOW_BCODE patron attribute in the English web
installers .sql and .txt file is also in the Norwegian web installers
.sql and .txt file

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2019-01-17 20:22:32 UTC
Note: I checked that the two files from the installer are now in the Norwegian web installer folder.

I didn't test by running through the actual installer.
Comment 4 Katrin Fischer 2019-01-20 14:27:19 UTC
Created attachment 84252 [details] [review]
Bug 11922: Added SHOW_BCODE patron attribute for Norwegian web installer

Test plan:
1. Notice that /patron_attributes.sql and /patron_attributes.txt can be
located in 2-Valgfritt
2. Confirm that the SHOW_BCODE patron attribute in the English web
installers .sql and .txt file is also in the Norwegian web installers
.sql and .txt file

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2019-01-20 14:29:08 UTC
Created attachment 84253 [details] [review]
Bug 11922: Add SHOW_BCODE patron attribute for Norwegian web installer

Test plan:
1. Notice that /patron_attributes.sql and /patron_attributes.txt can be
located in 2-Valgfritt
2. Confirm that the SHOW_BCODE patron attribute in the English web
installers .sql and .txt file is also in the Norwegian web installers
.sql and .txt file

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2019-01-20 14:31:02 UTC
The new files haven't been translated to Norwegian, but I think this is still good as it bringes the nb-NO installer more in line with the others and allows to install the same data. Translation can be fixed later (hope Magnus agrees :) )
Comment 7 Magnus Enger 2019-01-21 08:37:46 UTC
(In reply to Katrin Fischer from comment #6)
> The new files haven't been translated to Norwegian, but I think this is
> still good as it bringes the nb-NO installer more in line with the others
> and allows to install the same data. Translation can be fixed later (hope
> Magnus agrees :) )

I totally agree!
Comment 8 Nick Clemens 2019-01-25 17:59:27 UTC
Awesome work all!

Pushed to master for 19.05
Comment 9 Martin Renvoize 2019-01-31 16:38:47 UTC
Pushed to 18.11.x for 18.11.03
Comment 10 Lucas Gass 2019-02-01 21:19:21 UTC
pushed to 18.05.x for 18.05.09
Comment 11 Fridolin Somers 2019-02-04 12:11:16 UTC
Pushed to 17.11.x for 17.11.15