Summary: | Replace given by if-else in Circulation_issuingrules.t | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicolas Legrand <nicolas.legrand> |
Component: | Test Suite | Assignee: | Nicolas Legrand <nicolas.legrand> |
Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | fridolin.somers, kyle, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 11934 - Replace given by if-else statments
Bug 11934 - Replace given by if-else statments Bug 11934 - Replace given by if-else statments [SIGNED OFF] Bug 11934 - Replace given by if-else statments [PASSED QA] Bug 11934 - Replace given by if-else statments |
Description
Nicolas Legrand
2014-03-13 09:31:36 UTC
Created attachment 26231 [details] [review] Bug 11934 - Replace given by if-else statments Created attachment 26238 [details] [review] Bug 11934 - Replace given by if-else statments Created attachment 26242 [details] [review] Bug 11934 - Replace given by if-else statments Created attachment 26248 [details] [review] [SIGNED OFF] Bug 11934 - Replace given by if-else statments Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Comment on attachment 26242 [details] [review] Bug 11934 - Replace given by if-else statments Great work, cleans up code and maintains correct function. Signed off, go forth and QA Created attachment 26272 [details] [review] [PASSED QA] Bug 11934 - Replace given by if-else statments Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> replaces given-when with if-elsif-else constructs. Tests still pass and code looks good. Pushed to master, along with a follow-up to tidy up whitespace. This appears to be your first commit pushed to Koha master. Congratulations, Nicolas! Thank you ^^ and thanks to Katrin and Martin who very kindly proposed it to me. Pushed to 3.14.x, will be in 3.14.08 Congratulations Nicolas, you're in stable branch also ;) Pushed to 3.12.x, will be in 3.12.13 |