Description
Zeno Tajoli
2014-03-14 10:49:53 UTC
Created attachment 26339 [details] [review] better default for currencies, eng setup Created attachment 26380 [details] [review] [SIGNED OFF] Bug 11939 - Better default for currencies This patch offers a better default for currencies, with USA dollar as default active currency. To test the patch: 1)Install master without the patch, during web installation select 'parameters.sql' file 2)Finish install and go to Administration -Currencies & Exchange rates 3)No active currency 4)Install master with this patch, during web installation select 'parameters.sql' file 5)Finish install and go to Administration -Currencies & Exchange rates 6)Now USA dollar is the active currency http://bugs.koha-community.org/show_bug.cgi?id=11939 NOTE: This does solve the problem of everything being NULL for active, and lacking an active value. It also corrects the description of the optional item to check related to currencies. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 26415 [details] [review] Bug 11939: Add active currency for all data files Test plan: insert all sql files modified by this patch and verify the data is correctly inserted. Zeno, I completely agree but I think the change should be done for all languages data. Ok, no problem. In your opipion canI check you patch ? Because I find difficult that someone wants to try six installation in 6 different languages. mysql < /path/to/file.sql for each one should be enough. GAH! I think you were right to complain about the other currency files, Jonathan. However, did you not see how they differed? It would be nice if they were all standardized. All the currencies used in all the currency files should be in the currency files on every other language, though the default and active one should not be the same. (In reply to M. Tompsett from comment #7) > All the currencies used in all the currency files should be in the currency > files on every other language, though the default and active one should not > be the same. Yes, it is what my patch does, if I understand you well. The only difference between 2 currency files would be the "active" value. After discussing with Jonathan on IRC, we agreed to lock the scope of this to just adding the active column into the samples, and that another bug will deal with the clean up of the sample currency files. I am not sure that every file should have the same currencies. Depending on where you are you might order books from other countries - countries with the same language or neighbouring countries etc. I think it should be ok to leave some room for customizing those. Created attachment 26439 [details]
Generates currency sql files to copy into place.
What I was thinking about.
Created attachment 26440 [details] [review] [SIGNED OFF] Bug 11939: Add active currency for all data files Revised Test Plan ----------------- The following SQL commands were used to test this. installer/data/mysql/en/optional/parameters.sql is part of the first patch and didn't really need testing again. installer/data/mysql/de-DE/optional/parameters.sql is not part of the patch, but since I was playing with the script, which is also attached here, it was included for good measure. use kohadata; SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/pl-PL/optional/parameters.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/es-ES/optional/parameters.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/ru-RU/optional/sample_currency.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/uk-UA/optional/sample_currency.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/it-IT/necessari/parameters.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/de-DE/optional/parameters.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/nb-NO/2-Valgfritt/parameters.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/en/optional/parameters.sql Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 26523 [details] [review] [PASSED QA] Bug 11939 - Better default for currencies This patch offers a better default for currencies, with USA dollar as default active currency. To test the patch: 1)Install master without the patch, during web installation select 'parameters.sql' file 2)Finish install and go to Administration -Currencies & Exchange rates 3)No active currency 4)Install master with this patch, during web installation select 'parameters.sql' file 5)Finish install and go to Administration -Currencies & Exchange rates 6)Now USA dollar is the active currency http://bugs.koha-community.org/show_bug.cgi?id=11939 NOTE: This does solve the problem of everything being NULL for active, and lacking an active value. It also corrects the description of the optional item to check related to currencies. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes all tests and QA script. Created attachment 26524 [details] [review] [PASSED QA] Bug 11939: Add active currency for all data files Revised Test Plan ----------------- The following SQL commands were used to test this. installer/data/mysql/en/optional/parameters.sql is part of the first patch and didn't really need testing again. installer/data/mysql/de-DE/optional/parameters.sql is not part of the patch, but since I was playing with the script, which is also attached here, it was included for good measure. use kohadata; SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/pl-PL/optional/parameters.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/es-ES/optional/parameters.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/ru-RU/optional/sample_currency.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/uk-UA/optional/sample_currency.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/it-IT/necessari/parameters.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/de-DE/optional/parameters.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/nb-NO/2-Valgfritt/parameters.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/en/optional/parameters.sql Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Pushed to master. Thanks, Jonathan and Zeno! Pushed to 3.14.x, will be in 3.14.08 Pushed to 3.12.x, will be in 3.12.13 |