Summary: | "Patron lists" are not easily accessible | ||
---|---|---|---|
Product: | Koha | Reporter: | Olli-Antti Kivilahti <olli-antti.kivilahti> |
Component: | Patrons | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, gmcharlt, jonathan.druart, kyle.m.hall, m.de.rooy, mtj, mtompset, tomascohen, wizzyrea |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 10565 | ||
Bug Blocks: | |||
Attachments: |
Bug 11941: Add link to patron lists from the patron home page
Bug 11941: Add link to patron lists from the patron home page Bug 11941: Add link to patron lists from the patron home page Bug 11941: Add link to patron lists from the patron home page |
Description
Olli-Antti Kivilahti
2014-03-14 11:26:06 UTC
I think it would make more sense to incorporate links to patrons lists functionality from the patrons home page. Created attachment 38598 [details] [review] Bug 11941: Add link to patron lists from the patron home page The patron lists are only accessible from the tools module, which is not easily accessible when you are in the patron module. Test plan: Go on the patron home page. In the toolbar, you should see a link to the patron lists. Comment on attachment 38598 [details] [review] Bug 11941: Add link to patron lists from the patron home page Review of attachment 38598 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc @@ +6,5 @@ > [% FOREACH category IN categories %]<li><a href="/cgi-bin/koha/members/memberentry.pl?op=add&categorycode=[% category.categorycode %]">[% category.description %]</a></li>[% END %] > </ul> > </div> > + [% IF CAN_user_tools_manage_patron_lists %] > + <button class="btn btn-small" href="/cgi-bin/koha/patron_lists/lists.pl"><i class="icon-edit"></i>Patron lists</button> This isn't inside a form, as far as I can tell. Please change 'button' to 'a'. I couldn't get it to meaningfully click with 'button'. Created attachment 38878 [details] [review] Bug 11941: Add link to patron lists from the patron home page The patron lists are only accessible from the tools module, which is not easily accessible when you are in the patron module. Test plan: Go on the patron home page. In the toolbar, you should see a link to the patron lists. NOTE: Tweaked button to a to get the click to work. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 38879 [details] [review] Bug 11941: Add link to patron lists from the patron home page The patron lists are only accessible from the tools module, which is not easily accessible when you are in the patron module. Test plan: Go on the patron home page. In the toolbar, you should see a link to the patron lists. NOTE: Tweaked button to a to get the click to work. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Liz Rea <liz@catalyst.net.nz> Created attachment 38964 [details] [review] Bug 11941: Add link to patron lists from the patron home page The patron lists are only accessible from the tools module, which is not easily accessible when you are in the patron module. Test plan: Go on the patron home page. In the toolbar, you should see a link to the patron lists. NOTE: Tweaked button to a to get the click to work. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Liz Rea <liz@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Patch pushed to master. Thanks Jonathan! Pushed to 3.20.x will be in 3.20.1 Patch pushed to 3.18.x will be in 3.18.08 Contains string changes, holding till 3.16.14 |