Summary: | OPAC search suggestions template error | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | alex, fridolin.somers, gmcharlt |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 11951 - OPAC search suggestions template error
Bug 11951 - OPAC search suggestions template error [PASSED QA] Bug 11951 - OPAC search suggestions template error |
Description
Nicole C. Engard
2014-03-17 13:17:23 UTC
Nevermind, I caught it - it goes here: http://kohavm/cgi-bin/koha/svc/suggestion?render=standalone&q=32298 Which is an error page for me in Master and on 3.14.3: Software error: Template process failed: file error - cssinclude: not found at /home/nengard/kohaclone/C4/Templates.pm line 132. Created attachment 26406 [details] [review] Bug 11951 - OPAC search suggestions template error If you have search suggestions enabled in the OPAC and click the "Check for suggestions" link before it is replaced with the JS-rendered output you will get a template error. This patch corrects it. To test you must have the bootstrap theme enabled and at least one OPAC plugin enabled in Administration -> Did you mean? - Perform a search in the OPAC. - Look for a box which says "Not what you expected? Check for suggestions" - Click the "Check for suggestions" link before it disappears. If necessary disable JavaScript in your browser so that the link doesn't disappear. - The search suggestions page should render without errors. (In reply to Nicole C. Engard from comment #0) > Either that doesn't belong there or it > should show up for longer than it does - not sure where it goes. The message isn't really meant to be seen if the user has JavaScript enabled, that's why it disappears. JavaScript loads the content the user is meant to see as soon as it can. The page you see if you do click that link contains the same content which JavaScript loads directly into the search results page. The reason the link appears in the first place is so that users with JavaScript disabled are able to see the same content. Created attachment 26410 [details] [review] Bug 11951 - OPAC search suggestions template error If you have search suggestions enabled in the OPAC and click the "Check for suggestions" link before it is replaced with the JS-rendered output you will get a template error. This patch corrects it. To test you must have the bootstrap theme enabled and at least one OPAC plugin enabled in Administration -> Did you mean? - Perform a search in the OPAC. - Look for a box which says "Not what you expected? Check for suggestions" - Click the "Check for suggestions" link before it disappears. If necessary disable JavaScript in your browser so that the link doesn't disappear. - The search suggestions page should render without errors. Signed-off-by: A. Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> Created attachment 26433 [details] [review] [PASSED QA] Bug 11951 - OPAC search suggestions template error If you have search suggestions enabled in the OPAC and click the "Check for suggestions" link before it is replaced with the JS-rendered output you will get a template error. This patch corrects it. To test you must have the bootstrap theme enabled and at least one OPAC plugin enabled in Administration -> Did you mean? - Perform a search in the OPAC. - Look for a box which says "Not what you expected? Check for suggestions" - Click the "Check for suggestions" link before it disappears. If necessary disable JavaScript in your browser so that the link doesn't disappear. - The search suggestions page should render without errors. Signed-off-by: A. Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> The non-Javascript fallback link now works correctly. Passes tests and QA script. Pushed to master. Thanks, Owen! Pushed to 3.14.x, will be in 3.14.10 |