Bug 11954

Summary: Clean up currency default files
Product: Koha Reporter: Mark Tompsett <mtompset>
Component: Installation and upgrade (web-based installer)Assignee: Mark Tompsett <mtompset>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: chris, gmcharlt, mtj, tomascohen
Version: Main   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 11954 - Clean up currency default files
Bug 11954 - Clean up currency default files
[PASSED QA] Bug 11954 - Clean up currency default files

Description Mark Tompsett 2014-03-18 20:06:45 UTC
The files are not standardized, and with the intended addition of active on bug 11939, this bug will clean the files up further.

TRUNCATE? Foreign key checks? It doesn't make sense to have all these differences.
Comment 1 Mark Tompsett 2014-11-19 18:41:41 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2015-01-28 13:25:29 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2015-01-30 12:28:07 UTC
Created attachment 35618 [details] [review]
[PASSED QA] Bug 11954 - Clean up currency default files

It makes no sense to have TRUNCATE or foreign key checks.

TEST PLAN
---------
1) Back up your database
2) in an mysql client:
     use kohadata;
     SET FOREIGN_KEY_CHECKS=0;
     TRUNCATE currency;
     source /home/mtompset/kohaclone/installer/data/mysql/ru-RU/optional/sample_currency.sql
     SET FOREIGN_KEY_CHECKS=0;
     TRUNCATE currency;
     source /home/mtompset/kohaclone/installer/data/mysql/uk-UA/optional/sample_currency.sql
     SET FOREIGN_KEY_CHECKS=0;
     TRUNCATE currency;
     source /home/mtompset/kohaclone/installer/data/mysql/it-IT/necessari/parameters.sql
     SET FOREIGN_KEY_CHECKS=1;
     QUIT
   -- These should all work without problem.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi 2015-02-09 18:58:38 UTC
Patch pushed to master.

Thanks Mark!
Comment 5 Chris Cormack 2015-02-14 06:57:36 UTC
Pushed to 3.18.x will be in 3.18.4
Comment 6 Mason James 2015-02-26 04:35:20 UTC
Pushed to 3.16.x, will be in 3.16.8