Summary: | Clean up currency default files | ||
---|---|---|---|
Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
Component: | Installation and upgrade (web-based installer) | Assignee: | Mark Tompsett <mtompset> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, gmcharlt, mtj, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 11954 - Clean up currency default files
Bug 11954 - Clean up currency default files [PASSED QA] Bug 11954 - Clean up currency default files |
Description
Mark Tompsett
2014-03-18 20:06:45 UTC
Created attachment 33688 [details] [review] Bug 11954 - Clean up currency default files It makes no sense to have TRUNCATE or foreign key checks. TEST PLAN --------- 1) Back up your database 2) in an mysql client: use kohadata; SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/ru-RU/optional/sample_currency.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/uk-UA/optional/sample_currency.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/it-IT/necessari/parameters.sql SET FOREIGN_KEY_CHECKS=1; QUIT -- These should all work without problem. 3) Restore database Created attachment 35579 [details] [review] Bug 11954 - Clean up currency default files It makes no sense to have TRUNCATE or foreign key checks. TEST PLAN --------- 1) Back up your database 2) in an mysql client: use kohadata; SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/ru-RU/optional/sample_currency.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/uk-UA/optional/sample_currency.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/it-IT/necessari/parameters.sql SET FOREIGN_KEY_CHECKS=1; QUIT -- These should all work without problem. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 35618 [details] [review] [PASSED QA] Bug 11954 - Clean up currency default files It makes no sense to have TRUNCATE or foreign key checks. TEST PLAN --------- 1) Back up your database 2) in an mysql client: use kohadata; SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/ru-RU/optional/sample_currency.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/uk-UA/optional/sample_currency.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/it-IT/necessari/parameters.sql SET FOREIGN_KEY_CHECKS=1; QUIT -- These should all work without problem. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Mark! Pushed to 3.18.x will be in 3.18.4 Pushed to 3.16.x, will be in 3.16.8 |