Bug 11957

Summary: sample_only_param_tables.sql is not usable
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, gmcharlt, kyle, mtompset
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 11957: sample_only_param_tables.sql is not usable
[SIGNED OFF] Bug 11957: sample_only_param_tables.sql is not usable
[PASSED QA] Bug 11957: sample_only_param_tables.sql is not usable

Description Jonathan Druart 2014-03-19 12:11:00 UTC
This sql file tries to insert data into nonexistent tables.
It is useless and can be removed.
Comment 1 Jonathan Druart 2014-03-19 12:13:04 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2014-03-19 12:18:11 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-03-22 09:05:35 UTC
Created attachment 26518 [details] [review]
[PASSED QA] Bug 11957: sample_only_param_tables.sql is not usable

This sql file tries to insert data into nonexistent tables.
It is useless and can be removed.

Test plan:
  git grep sample_only_param_tables
should not return any result.

NOTE: This is basically a git rm. Simple patch.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
File is not used by the installers and it wouldn't work
with today's Koha for trying to insert data into non-existant
tables and tables with different structure.
Comment 4 Galen Charlton 2014-03-22 12:42:28 UTC
Pushed to master.  Thanks, Jonathan!
Comment 5 Fridolin Somers 2014-06-12 09:17:35 UTC
Pushed to 3.14.x, will be in 3.14.08
Comment 6 Kyle M Hall (khall) 2014-06-13 13:04:32 UTC
Pushed to 3.12.x, will be in 3.12.13