Description
Frédérick Capovilla
2014-03-19 16:22:00 UTC
Comment hidden (obsolete)
Created attachment 26516 [details] [review] [SIGNED-OFF] Add a "Z39.50 search" button to the authority creation and modification pages. This button lets you replace existing authorities using a Z39.50 search. http://bugs.koha-community.org/show_bug.cgi?id=11961 Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests pass FAIL authorities/authorities.pl FAIL critic # Subroutines::ProhibitSubroutinePrototypes: Got 1 violation(s). Created attachment 29867 [details] [review] Fix the ProhibitedSubroutinePrototypes QA critical error by removing the ($) from the GetMandatoryFieldZ3950 function http://bugs.koha-community.org/show_bug.cgi?id=9961 Critical problem fixed Comment on attachment 26516 [details] [review] [SIGNED-OFF] Add a "Z39.50 search" button to the authority creation and modification pages. Review of attachment 26516 [details] [review]: ----------------------------------------------------------------- Hi Eric, I have used the splinter review to add my comments. I like this addition, please provide a follow-up. ::: authorities/authorities.pl @@ +344,4 @@ > return int(rand(1000000)); > } > > +=item GetMandatoryFieldZ3950 Hard coding the fields in many places is a problem - please refactor so that it is using the same method as GuessAuthTypeCode. It also needs to be MARC agnostic (support UNIMARC) and have unit tests. ::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt @@ +201,4 @@ > <br />Go to page : <input id="goto_page" name="goto_page" value="[% current_page %]" size="4" /><input type="submit" name="changepage_goto" onclick="return validate_goto_page();" value="Go" /> > </form> > > +<p><form method="get" action="/cgi-bin/koha/cataloguing/z3950_auth_search.pl"><input type="hidden" name="authid" value="[% authid %]" /><input type="submit" value="Try Another Search"/></form></p> Please fix the capitalization here (I know it was wrong before, but this is a good moment to do it). @@ +214,4 @@ > </div> > [% END %] > <div class="dialog message">Nothing found.</div> > + <p><form method="get" action="/cgi-bin/koha/cataloguing/z3950_auth_search.pl"><input type="hidden" name="authid" value="[% authid %]" /><input type="submit" value="Try Another Search"/></form></p> Also here. Created attachment 30772 [details] [review] This patch fix the QA critical error, fix the capitalization and the UNIMARC support. Created attachment 35418 [details] [review] This patch fix the QA critical error, fix the capitalization and the UNIMARC support. http://bugs.koha-community.org/show_bug.cgi?id=11961 Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Created attachment 35490 [details] [review] [PASSED QA] Bug 11961 - Add a "Z39.50 search" button to the authority creation and modification pages. This button lets you replace existing authorities using a Z39.50 search. http://bugs.koha-community.org/show_bug.cgi?id=11961 Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests pass Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 35491 [details] [review] [PASSED QA] Bug 11961 - This patch fix the QA critical error, fix the capitalization and the UNIMARC support. http://bugs.koha-community.org/show_bug.cgi?id=11961 Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patches pushed to master. Thanks Frederik! |