Summary: | OverDrive API now prepends http:// to URLs | ||
---|---|---|---|
Product: | Koha | Reporter: | Jesse Weaver <jweaver> |
Component: | OPAC | Assignee: | Jesse Weaver <jweaver> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P1 - high | CC: | fridolin.somers, gmcharlt, mtj |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 11978 - Fix URLs displayed in OverDrive search
[SIGNED-OFF] Bug 11978 - Fix URLs displayed in OverDrive search [PASSED QA] Bug 11978 - Fix URLs displayed in OverDrive search |
Description
Jesse Weaver
2014-03-20 17:20:18 UTC
Created attachment 26497 [details] [review] Bug 11978 - Fix URLs displayed in OverDrive search OverDrive has recently changed its APIs to include "http://" in the URLs it returns. This patch removes the "http://" on the Koha end so they aren't doubled. Test plan: 1. Run an OverDrive search on the OPAC. 2. Check the links, they should start with "http://http://" 3. Apply this patch. 4. Rerun the search, the links should now be correct. Raising importance, as this blocks clicking of links in any OPAC using OverDrive. Good candidate for a maintenance patch. Created attachment 26856 [details] [review] [SIGNED-OFF] Bug 11978 - Fix URLs displayed in OverDrive search OverDrive has recently changed its APIs to include "http://" in the URLs it returns. This patch removes the "http://" on the Koha end so they aren't doubled. Test plan: 1. Run an OverDrive search on the OPAC. 2. Check the links, they should start with "http://http://" 3. Apply this patch. 4. Rerun the search, the links should now be correct. Signed-off-by: Owen Leonard <oleonard@myacpl.org> I can reproduce the problem and confirm that this patch fixes it. Created attachment 26885 [details] [review] [PASSED QA] Bug 11978 - Fix URLs displayed in OverDrive search OverDrive has recently changed its APIs to include "http://" in the URLs it returns. This patch removes the "http://" on the Koha end so they aren't doubled. Test plan: 1. Run an OverDrive search on the OPAC. 2. Check the links, they should start with "http://http://" 3. Apply this patch. 4. Rerun the search, the links should now be correct. Signed-off-by: Owen Leonard <oleonard@myacpl.org> I can reproduce the problem and confirm that this patch fixes it. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch removes hardcoded http:// from URLs in the Overdrive code. Trusting Jesse and Owen to have tested this with Overdrive, code review reveals no additional changes or possible problems. Pushed to master. Thanks, Jesse! Pushed to 3.14.x, will be in 3.14.09 |