Summary: | staff users can set hold suspension dates to occur in the past | ||
---|---|---|---|
Product: | Koha | Reporter: | Galen Charlton <gmcharlt> |
Component: | Hold requests | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 12000: ensure that hold resumption dates can be set only to future dates
[SIGNED-OFF] Bug 12000: ensure that hold resumption dates can be set only to future dates [PASSED QA] Bug 12000: ensure that hold resumption dates can be set only to future dates |
Description
Galen Charlton
2014-03-26 17:12:51 UTC
Created attachment 26613 [details] [review] Bug 12000: ensure that hold resumption dates can be set only to future dates This patch makes the datepickers for the hold resumption date (AKA the hold suspend until date) field only permit dates in the future to be selected in the staff interface checkout page and hold list pages. This makes these pages consistent with the OPAC and the patron details page in the staff interface. To test: [1] Ensure that AutoResumeSuspendedHolds and SuspendHoldsIntranet are enabled. [2] Go to the checkout page for a patron that has at least one hold request. [3] Verify that the datepicker for the hold suspend until date field only permits choosing a date in the future. [4] Go to the page listing hold requests for a title. [5] Verify that the datepicker for the hold suspend until date fields only permit choosing a date in the future. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Created attachment 26687 [details] [review] [SIGNED-OFF] Bug 12000: ensure that hold resumption dates can be set only to future dates This patch makes the datepickers for the hold resumption date (AKA the hold suspend until date) field only permit dates in the future to be selected in the staff interface checkout page and hold list pages. This makes these pages consistent with the OPAC and the patron details page in the staff interface. To test: [1] Ensure that AutoResumeSuspendedHolds and SuspendHoldsIntranet are enabled. [2] Go to the checkout page for a patron that has at least one hold request. [3] Verify that the datepicker for the hold suspend until date field only permits choosing a date in the future. [4] Go to the page listing hold requests for a title. [5] Verify that the datepicker for the hold suspend until date fields only permit choosing a date in the future. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 26700 [details] [review] [PASSED QA] Bug 12000: ensure that hold resumption dates can be set only to future dates This patch makes the datepickers for the hold resumption date (AKA the hold suspend until date) field only permit dates in the future to be selected in the staff interface checkout page and hold list pages. This makes these pages consistent with the OPAC and the patron details page in the staff interface. To test: [1] Ensure that AutoResumeSuspendedHolds and SuspendHoldsIntranet are enabled. [2] Go to the checkout page for a patron that has at least one hold request. [3] Verify that the datepicker for the hold suspend until date field only permits choosing a date in the future. [4] Go to the page listing hold requests for a title. [5] Verify that the datepicker for the hold suspend until date fields only permit choosing a date in the future. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes all tests and QA script. Pushed to master. Pushed to 3.14.x, will be in 3.14.08 |