| Summary: | Add STMP authentication parameters to runreports.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Chris Nighswonger <cnighswonger> |
| Component: | Reports | Assignee: | Chris Nighswonger <cnighswonger> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | gmcharlt, mtompset |
| Version: | 3.14 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | Sponsored | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Patch to add auth params
Patch to add auth params Rebased patch [SIGNED OFF] Bug 12040 - Add 3 parameters for SMTP authentication Fixup documentation of new params [SIGNED OFF] Bug 12040 - Add 3 parameters for SMTP authentication Bug 12040 - Add 3 parameters for SMTP authentication |
||
|
Description
Chris Nighswonger
2014-04-07 15:36:23 UTC
Comment hidden (obsolete)
Comment on attachment 26872 [details] [review] Patch to add auth params Yikes! Monday strikes again. Created attachment 26873 [details] [review] Patch to add auth params This may overlap / cause rebase needs with bug 12031. Created attachment 26874 [details] [review] Rebased patch Created attachment 26875 [details] [review] [SIGNED OFF] Bug 12040 - Add 3 parameters for SMTP authentication -username -> Username to pass to the SMTP server for authentication -password -> Password to pass to the SMTP server for authentication -method -> Method is the type of authentication. Ie. LOGIN, DIGEST-MD5, etc. Test Plan --------- As for testing manually using a Gmail account: 1. Set up your sendmail as shown in misc/cronjobs/CONFIGURE.gmail 2. Before applying this patch, run misc/cronjobs/runreports.pl on your favorite report including the proper email parameters against your gmail account. 3. Note the failure message stating the authentication requirement. 4. Apply this patch, and return the script including the additional parameters and specifying "LOGIN" for the method. 5. Note the successful send. Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Note: My Mail/Sendmail.pm was in /usr/share/perl5/Mail/Sendmail.pm I tested the case with the patch applied, with and without expected parameters. The parameters don't exist before, so I don't see how to pass values for them. (In reply to M. Tompsett from comment #5) > expected parameters. The parameters don't exist before, so > I don't see how to pass values for them. Sorry. Running 'perldoc runreport.pl' should show them up along with all other available params. Created attachment 26876 [details] [review] Fixup documentation of new params Created attachment 26877 [details] [review] [SIGNED OFF] Bug 12040 - Add 3 parameters for SMTP authentication -username -> Username to pass to the SMTP server for authentication -password -> Password to pass to the SMTP server for authentication -method -> Method is the type of authentication. Ie. LOGIN, DIGEST-MD5, etc. Test Plan --------- As for testing manually using a Gmail account: 1. Set up your sendmail as shown in misc/cronjobs/CONFIGURE.gmail 2. Before applying this patch, run misc/cronjobs/runreports.pl on your favorite report including the proper email parameters against your gmail account. 3. Note the failure message stating the authentication requirement. 4. Apply this patch, and return the script including the additional parameters and specifying "LOGIN" for the method. 5. Note the successful send. 6. perldoc misc/cronjobs/runreport.pl 7. Run the koha qa test tool. Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Note: My Mail/Sendmail.pm was in /usr/share/perl5/Mail/Sendmail.pm I tested the case with the patch applied, with and without expected parameters. The parameters don't exist before, so I don't see how to pass values for them. Created attachment 27016 [details] [review] Bug 12040 - Add 3 parameters for SMTP authentication -username -> Username to pass to the SMTP server for authentication -password -> Password to pass to the SMTP server for authentication -method -> Method is the type of authentication. Ie. LOGIN, DIGEST-MD5, etc. Test Plan --------- As for testing manually using a Gmail account: 1. Set up your sendmail as shown in misc/cronjobs/CONFIGURE.gmail 2. Before applying this patch, run misc/cronjobs/runreports.pl on your favorite report including the proper email parameters against your gmail account. 3. Note the failure message stating the authentication requirement. 4. Apply this patch, and return the script including the additional parameters and specifying "LOGIN" for the method. 5. Note the successful send. 6. perldoc misc/cronjobs/runreport.pl 7. Run the koha qa test tool. Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Note: My Mail/Sendmail.pm was in /usr/share/perl5/Mail/Sendmail.pm I tested the case with the patch applied, with and without expected parameters. The parameters don't exist before, so I don't see how to pass values for them. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master. Thanks, Chris! |