|
Description
Jonathan Druart
2014-04-09 08:34:10 UTC
Created attachment 26914 [details] [review] Bug 12052: Display a patron message on the summary page Test plan: Fill the OPACMySummaryNote with html code or just text. The content should be displayed at the OPAC on the summary page for patrons. Works, but
1. Think you need to add the new syspref on installer/data/mysql/updatedatabase.pl
2. The check
if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) {
must be written
if ( CheckVersion($DBversion) ) {
because it does not run as is on master
(In reply to Bernardo Gonzalez Kriegel from comment #2) > Works, but > > 1. Think you need to add the new syspref on > installer/data/mysql/updatedatabase.pl In sysprefs.sql, yes :) > 2. The check > if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) { > must be written > if ( CheckVersion($DBversion) ) { > because it does not run as is on master Oops, originally this patch was for a 3.10 branch, I forgot to change that. New patch coming. Created attachment 27076 [details] [review] Bug 12052: Display a patron message on the summary page Test plan: Fill the OPACMySummaryNote with html code or just text. The content should be displayed at the OPAC on the summary page for patrons. Created attachment 27097 [details] [review] [SIGNED-OFF] Bug 12052: Display a patron message on the summary page Test plan: Fill the OPACMySummaryNote with html code or just text. The content should be displayed at the OPAC on the summary page for patrons. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. No koha-qa errors Created attachment 27150 [details] [review] [PASSED QA] Bug 12052: Display a patron message on the summary page Test plan: Fill the OPACMySummaryNote with html code or just text. The content should be displayed at the OPAC on the summary page for patrons. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. No koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes tests and QA script. Rephrased the pref text a little bit, using 'logged in' instead of 'connected'. Created attachment 27151 [details] [review] [PASSED QA] Bug 12052: Display a patron message on the summary page Test plan: Fill the OPACMySummaryNote with html code or just text. The content should be displayed at the OPAC on the summary page for patrons. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. No koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes tests and QA script. Rephrased the pref text a little bit, using 'logged in' instead of 'connected', also added " so the description appears correctly in the pref editor. Pushed to master. Thanks, Jonathan! Pushed to 3.14.x, will be in 3.14.10 |