This bug is still present in master 3.19. Created attachment 38594 [details] [review] Bug 12054: Inactive vendors should be inactive Bug 12054: Inactive vendors should be inactive This patch make inactive vendors really inactive. That means an inactive vendor won't be able to receive / add a basket / add an order. Test plan: In the acquisition module create 2 vendors: 1 active and 1 inactive. On the acqui/booksellers.pl, acqui/uncertainprice.pl, admin/aqcontract.pl and acqui/supplier.pl (pages which include the acq toolbar) pages, confirm that you are not able to receive shipments, create a new basket, add a new order for the inactive vendor. No change should exist for the active vendor. I have problems applying this patch with git bz
Traceback (most recent call last):
File "/usr/local/bin/git-bz", line 2633, in <module>
do_attach(*args)
File "/usr/local/bin/git-bz", line 1999, in do_attach
attach_commits(bug, commits, edit_comments=global_options.edit)
File "/usr/local/bin/git-bz", line 1914, in attach_commits
description, body, obsoletes, statuses, patch_complexities, depends = edit_attachment_comment(bug, commit.subject, body)
File "/usr/local/bin/git-bz", line 1867, in edit_attachment_comment
lines = edit_template(template.getvalue())
File "/usr/local/bin/git-bz", line 811, in edit_template
f.write(template)
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2019' in position 30: ordinal not in range(128)
(In reply to Indranil Das Gupta from comment #3) > I have problems applying this patch with git bz CORRECTION: s/applying/attaching Patch applies and works correctly as per test plan Created attachment 39236 [details] [review] Signed off patch for bug 12054 Created attachment 39237 [details] [review] Bug 12054: Inactive vendors should be inactive Created attachment 39238 [details] [review] Bug 12054: Inactive vendors should be inactive This patch make inactive vendors really inactive. That means an inactive vendor would not be able to receive / add a basket / add an order. Revised test plan ================= 1/ In the acquisition module create 2 vendors: 1 active and 1 inactive. 2/ On the acqui/booksellers.pl, acqui/uncertainprice.pl, admin/aqcontract.pl and acqui/supplier.pl (pages which include the acq toolbar), you should be able to, for both the 'active' as well as the inactive vendor : (a) add new basket (b) add order items to the basket (c) receive shipment and enter invoice details and files Remark: This is *wrong*. You should be able to do so only for active vendor. 3/ Apply the patch 4/ Go to the links in step #2 above and select the inactive vendor you should no longer be able to: (a) add new basket (b) add order items to the basket (c) receive shipment and enter invoice details and files Remark: This is the *correct* behaviour 5/ No change should be noted for vendor marked "active", and should be able to undertake operations 4 (a), 4 (b) and 4 (c). Remark: This is the *correct* behaviour. 6/ run koha qa tests tool Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Remarks: Testing result match expected test plan output. The QA tests pass with "OK" for the commit. Hi Indranil, make sure you have checked out the latest version of the fishsoup branch from the git-bz repository on kc.org - that should make the problem disappear. I wonder: should we allow receiving shipments for inactive vendors? There might still be orderes outstanding,when you decide that you don't want to use the vendor for odering in the future. Hm, also, I can still: - reopen the baskt - add new orders This is possible by using the 'view' link from the vendor search page. Created attachment 39796 [details] [review] Bug 12054: (follow-up) Inactive vendors should be inactive Don't display "add order""block and buttons if the vendor is inactive. (In reply to Katrin Fischer from comment #9) > I wonder: should we allow receiving shipments for inactive vendors? There > might still be orderes outstanding,when you decide that you don't want to > use the vendor for odering in the future. (In reply to Katrin Fischer from comment #10) > Hm, also, I can still: > - reopen the baskt > - add new orders > > This is possible by using the 'view' link from the vendor search page. This patch only prevents to add order to an inactive vendor. The second one fixes 2 more occurrences where it was possible to add orders (on the basket page). > > This is possible by using the 'view' link from the vendor search page.
>
> This patch only prevents to add order to an inactive vendor.
Hi Jonathan, this is not quite correct - you also remove 2 of the 'receive shipments' links, one being in the vendor search result list. I am a bit worried about those, as it will make it difficult to receive pending orders from a 'blocked for future use' vendor. Could we keep them?
Created attachment 40178 [details] [review] Bug 12054: Inactive vendors should be inactive This patch make inactive vendors really inactive. That means an inactive vendor would not be able to add a basket / add an order. Revised test plan ================= 1/ In the acquisition module create 2 vendors: 1 active and 1 inactive. 2/ On the acqui/booksellers.pl, acqui/uncertainprice.pl, admin/aqcontract.pl and acqui/supplier.pl (pages which include the acq toolbar), you should be able to, for both the 'active' as well as the inactive vendor : (a) add new basket (b) add order items to the basket Remark: This is *wrong*. You should be able to do so only for active vendor. 3/ Apply the patch 4/ Go to the links in step #2 above and select the inactive vendor you should no longer be able to: (a) add new basket (b) add order items to the basket Remark: This is the *correct* behaviour 5/ No change should be noted for vendor marked "active", and should be able to undertake operations 4 (a), 4 (b) and 4 (c). Remark: This is the *correct* behaviour. 6/ run koha qa tests tool Bug 12054: (follow-up) Inactive vendors should be inactive Don't display "add order""block and buttons if the vendor is inactive. The 2 patches have been squashed and the 'receive shipments' links reintroduced for inactive vendors. Back to Needs Signoff Created attachment 40204 [details] [review] Bug 12054: Inactive vendors should be inactive Created attachment 40205 [details] [review] Bug 12054: Inactive vendors should be inactive This patch make inactive vendors really inactive. That means an inactive vendor would not be able to add a basket / add an order. Revised test plan ================= 1/ In the acquisition module create 2 vendors: 1 active and 1 inactive. 2/ On the acqui/booksellers.pl, acqui/uncertainprice.pl, admin/aqcontract.pl and acqui/supplier.pl (pages which include the acq toolbar), you should be able to, for both the 'active' as well as the inactive vendor : (a) add new basket (b) add order items to the basket Remark: This is *wrong*. You should be able to do so only for active vendor. 3/ Apply the patch 4/ Go to the links in step #2 above and select the inactive vendor you should no longer be able to: (a) add new basket (b) add order items to the basket Remark: This is the *correct* behaviour 5/ No change should be noted for vendor marked "active", and should be able to undertake operations 4 (a), 4 (b) and 4 (c). Remark: This is the *correct* behaviour. 6/ run koha qa tests tool Bug 12054: (follow-up) Inactive vendors should be inactive Don't display "add order""block and buttons if the vendor is inactive. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Created attachment 40925 [details] [review] [PASSED QA] Bug 12054: Inactive vendors should be inactive This patch make inactive vendors really inactive. That means an inactive vendor would not be able to add a basket / add an order. Revised test plan ================= 1/ In the acquisition module create 2 vendors: 1 active and 1 inactive. 2/ On the acqui/booksellers.pl, acqui/uncertainprice.pl, admin/aqcontract.pl and acqui/supplier.pl (pages which include the acq toolbar), you should be able to, for both the 'active' as well as the inactive vendor : (a) add new basket (b) add order items to the basket Remark: This is *wrong*. You should be able to do so only for active vendor. 3/ Apply the patch 4/ Go to the links in step #2 above and select the inactive vendor you should no longer be able to: (a) add new basket (b) add order items to the basket Remark: This is the *correct* behaviour 5/ No change should be noted for vendor marked "active", and should be able to undertake operations 4 (a), 4 (b) and 4 (c). Remark: This is the *correct* behaviour. 6/ run koha qa tests tool Bug 12054: (follow-up) Inactive vendors should be inactive Don't display "add order""block and buttons if the vendor is inactive. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Jonathan! |
Created attachment 26915 [details] Order from an inactive vendor When you make a vendor inactive, koha is able to order from it although if the help says you it’s not possible (see the attachment). I think it would be convenient to have at least a message that inform you of the vendor status.