| Summary: | Publisher code always empty on invoice | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Acquisitions | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | chris, mtj, paola.rossi, tomascohen |
| Version: | 3.16 | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | cgi-bin/koha/acqui/invoice.pl?invoiceid=34 | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 12059: Publisher column on invoice page always empty
Bug 12059: Publisher column on invoice page always empty Bug 12059: Publisher column on invoice page always empty Bug 12059: Prefer to list fields in the query |
||
|
Description
Katrin Fischer
2014-04-09 16:50:48 UTC
Created attachment 33411 [details] [review] Bug 12059: Publisher column on invoice page always empty This patch moves the publisher information out of its own always empty column into the Summary column below the title, as it is on other acq pages. The information was never displaying, as publishercode is in biblioitems and that table was not selected by GetInvoiceDetails. Also modified the code to take into account that UNIMARC uses biblioitems.publicationyear and MARC21/NORMARC use bibio.copyrightdate for the copyright year. To test: - create an invoice for records that - have a publication year - have no publication year - have a publisher... - 'finish receiving' and check the invoice summary page ...acqui/invoice.pl?invoiceid=? - Make sure all the information displays now but didn't witout the patch. There are tests for GetInvoiceDetails in t/Aquisisions... and t/db_dependent/... - I am not sure if more testing is needed for the new table and how the test should look like. Leaving the patch here as I don't know when I can get back to it. Created attachment 34088 [details] [review] Bug 12059: Publisher column on invoice page always empty Everything is ok as required. So I pass the patch to "Signed Off" status. Created attachment 34126 [details] [review] Bug 12059: Publisher column on invoice page always empty This patch moves the publisher information out of its own always empty column into the Summary column below the title, as it is on other acq pages. The information was never displaying, as publishercode is in biblioitems and that table was not selected by GetInvoiceDetails. Also modified the code to take into account that UNIMARC uses biblioitems.publicationyear and MARC21/NORMARC use bibio.copyrightdate for the copyright year. To test: - create an invoice for records that - have a publication year - have no publication year - have a publisher... - 'finish receiving' and check the invoice summary page ...acqui/invoice.pl?invoiceid=? - Make sure all the information displays now but didn't witout the patch. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 34127 [details] [review] Bug 12059: Prefer to list fields in the query To avoir further issue, it's better to explicitely list the fields we want to retrieve. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Patches pushed to master. Thanks Katrina and Jonathan! Template changes, holding for 3.18.3 Pushed to 3.18.x will be in 3.18.3 Template changes, holding for 3.16.8 Pushed to 3.16.x, will be in 3.16.7 |