| Summary: | Consistent use of encode_qp when sending basket/shelf | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | bgkriegel, gmcharlt |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 12065: Consistent use of encode_qp when sending basket/shelf
Bug 12065: Consistent use of encode_qp when sending basket/shelf [SIGNED-OFF] Bug 12065: Consistent use of encode_qp when sending basket/shelf [PASSED QA] Bug 12065: Consistent use of encode_qp when sending basket/shelf |
||
|
Description
Marcel de Rooy
2014-04-10 13:13:45 UTC
Created attachment 26975 [details] [review] Bug 12065: Consistent use of encode_qp when sending basket/shelf QP-encode both mail header and mail body when sending baskets or shelves. There is no need to Encode qp-encoded strings. Note that this does not solve all possible encoding problems in the mail sent. This is related to decoding CGI parameters and use of TT. That problem is addressed in report 11944. Test plan: Verify if sending a basket from opac and staff still works. Check if sending a shelf (list) from opac and staff still functions as expected. Created attachment 27362 [details] [review] Bug 12065: Consistent use of encode_qp when sending basket/shelf QP-encode both mail header and mail body when sending baskets or shelves. There is no need to Encode qp-encoded strings. Note that this does not solve all possible encoding problems in the mail sent. This is related to decoding CGI parameters and use of TT. That problem is addressed in report 11944. Test plan: Verify if sending a basket from opac and staff still works. Check if sending a shelf (list) from opac and staff still functions as expected. Created attachment 27743 [details] [review] [SIGNED-OFF] Bug 12065: Consistent use of encode_qp when sending basket/shelf QP-encode both mail header and mail body when sending baskets or shelves. There is no need to Encode qp-encoded strings. Note that this does not solve all possible encoding problems in the mail sent. This is related to decoding CGI parameters and use of TT. That problem is addressed in report 11944. Test plan: Verify if sending a basket from opac and staff still works. Check if sending a shelf (list) from opac and staff still functions as expected. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Cart/List sent form opac/staff works No koha-qa errors Created attachment 28131 [details] [review] [PASSED QA] Bug 12065: Consistent use of encode_qp when sending basket/shelf QP-encode both mail header and mail body when sending baskets or shelves. There is no need to Encode qp-encoded strings. Note that this does not solve all possible encoding problems in the mail sent. This is related to decoding CGI parameters and use of TT. That problem is addressed in report 11944. Test plan: Verify if sending a basket from opac and staff still works. Check if sending a shelf (list) from opac and staff still functions as expected. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Cart/List sent form opac/staff works No koha-qa errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master. Thanks, Marcel! |