Summary: | New renew page in staff client doesn't record branch in statistics | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Circulation | Assignee: | Kyle M Hall <kyle> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | chris, gmcharlt, kyle.m.hall, kyle, mtj, tomascohen, wizzyrea |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 12066 - New renew page in staff client doesn't record branch in statistics
[SIGNED-OFF] Bug 12066: New renew page in staff client doesn't record branch in statistics [PASSED QA] Bug 12066: New renew page in staff client doesn't record branch in statistics |
Description
Nicole C. Engard
2014-04-10 14:23:28 UTC
As far as I can tell this bug only affects renewals which are done through the new renew script (circ/renew.pl). I tried doing renewals through the OPAC (both by clicking on the link and by checking boxes and submitting the form) and in the staff client (by scanning a barcode in the checkout form and by checking boxes in the table of checked out items). Only when I use circ/renew.pl does the branch end up NULL. I notice that opac-renew.pl contains all the logic for determining which branch should be passed to AddRenewal(). I would think that logic should be separated out so that it doesn't have to be duplicated. > I notice that opac-renew.pl contains all the logic for determining which
> branch should be passed to AddRenewal().
Which, now that I actually think it through, is unnecessary for circ/renew.pl because we have the logged-in branch to pass to AddRenewal.
Created attachment 39351 [details] [review] Bug 12066 - New renew page in staff client doesn't record branch in statistics Test Plan: 1) Apply this patch 2) Renew an item via circ/renew.pl 3) Note the branch code of your logged in library is set as the branch in the generated statistic line Created attachment 39703 [details] [review] [SIGNED-OFF] Bug 12066: New renew page in staff client doesn't record branch in statistics Test Plan: 1) Apply this patch 2) Renew an item via circ/renew.pl 3) Note the branch code of your logged in library is set as the branch in the generated statistic line Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested pre and post patch, now branch is saved No errors Created attachment 39722 [details] [review] [PASSED QA] Bug 12066: New renew page in staff client doesn't record branch in statistics Test Plan: 1) Apply this patch 2) Renew an item via circ/renew.pl 3) Note the branch code of your logged in library is set as the branch in the generated statistic line Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested pre and post patch, now branch is saved No errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Kyle! Pushed to 3.20.x will be in 3.20.1 Patch pushed to 3.18.x will be in 3.18.08 Pushed to 3.16.x, will be in 3.16.13 |