Summary: | jQueryUI upgrade broke keyboard shortcuts | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Staff interface | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 12075 - jQueryUI upgrade broke keyboard shortcuts
[Signed-off] Bug 12075 - jQueryUI upgrade broke keyboard shortcuts [PASSED QA] Bug 12075 - jQueryUI upgrade broke keyboard shortcuts |
Description
Owen Leonard
2014-04-11 16:36:45 UTC
Created attachment 27034 [details] [review] Bug 12075 - jQueryUI upgrade broke keyboard shortcuts The recent jQueryUI upgrade broke keyboard shortcuts in the staff client because of changes to the jQueryUI API. This patch fixes the problem. To test, apply the patch and clear your browser cache if necessary. - View any page in the staff which includes header search tabs for check out, check in, or catalog search (staff client home page or circulation page for instance). - Test the keyboard shortcuts: Alt-q for catalog search, Alt-u for check out, Alt-r for check in. - Each keyboard shortcut should select the correct tab. Created attachment 27084 [details] [review] [Signed-off] Bug 12075 - jQueryUI upgrade broke keyboard shortcuts The recent jQueryUI upgrade broke keyboard shortcuts in the staff client because of changes to the jQueryUI API. This patch fixes the problem. To test, apply the patch and clear your browser cache if necessary. - View any page in the staff which includes header search tabs for check out, check in, or catalog search (staff client home page or circulation page for instance). - Test the keyboard shortcuts: Alt-q for catalog search, Alt-u for check out, Alt-r for check in. - Each keyboard shortcut should select the correct tab. Followed test plan, patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 27106 [details] [review] [PASSED QA] Bug 12075 - jQueryUI upgrade broke keyboard shortcuts The recent jQueryUI upgrade broke keyboard shortcuts in the staff client because of changes to the jQueryUI API. This patch fixes the problem. To test, apply the patch and clear your browser cache if necessary. - View any page in the staff which includes header search tabs for check out, check in, or catalog search (staff client home page or circulation page for instance). - Test the keyboard shortcuts: Alt-q for catalog search, Alt-u for check out, Alt-r for check in. - Each keyboard shortcut should select the correct tab. Followed test plan, patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Confirmed that the shortcuts were broken before the patch and now work again after applying it. Pushed to master. Thanks, Owen! Pushed to 3.14.x, will be in 3.14.10 |