Summary: | Add CSS classes to item statuses in detail view | ||
---|---|---|---|
Product: | Koha | Reporter: | paxed <pasi.kallinen> |
Component: | Staff interface | Assignee: | David Roberts <david.roberts> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | aleisha, david.roberts, didier.gautheron, fridolin.somers, gmcharlt, lisettepalouse+koha, lucas, tomascohen |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.02
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 25804 | ||
Attachments: |
Add css classes to item statuses in detail view
Bug 12093: Add css classes to item statuses in detail view Bug 12093: Add CSS classes to item statuses in detail view Bug 12093: Add CSS classes to item statuses in detail view Bug 12093: (QA follow-up) Fix typo 'noteforloan' |
Description
paxed
2014-04-16 08:16:32 UTC
Assignee is not set and bug number is missing from commit message. This wasn't my patch, but will pick this up to try to resolve it as it is currently unassigned. Looks like most of the work has already been done. Looks like the code in detail.tt has changed so completely this bug might not even still be relevant. Will check. Created attachment 104629 [details] [review] Bug 12093: Add css classes to item statuses in detail view This patch adds classes where necessary to detail.pl To test: 1) Apply patch 2) View source of /cgi-bin/koha/catalogue/detail.pl to check that there are no orphaned statuses without classes. A great deal of the original patch is now obsolete. I've worked through the file and added classes where I think they are necessary - hopefully I haven't missed too many. I can't think of a nice way to test this, other than to view the page source so I hope that is OK. Created attachment 105299 [details] [review] Bug 12093: Add CSS classes to item statuses in detail view This patch adds classes where necessary to detail.pl To test: 1) Apply patch 2) View source of /cgi-bin/koha/catalogue/detail.pl to check that there are no orphaned statuses without classes. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 105859 [details] [review] Bug 12093: Add CSS classes to item statuses in detail view This patch adds classes where necessary to detail.pl To test: 1) Apply patch 2) View source of /cgi-bin/koha/catalogue/detail.pl to check that there are no orphaned statuses without classes. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 105860 [details] [review] Bug 12093: (QA follow-up) Fix typo 'noteforloan' Just changes one character in the noteforloan class to notforloan. I realized a little late that I was also the one to sign this off. Since it has already been sitting for almost a month and I actually tested it twice, risking to leave it as PQA. Pushed to master for 20.11, thanks to everybody involved! Hi, In my understanding <TITLE> is plain text https://html.spec.whatwg.org/#the-title-element An after this commit we get stuff like <html lang="en"> <head> <title>Koha › Catalog › <span class="titledetails">Details for The Korean Go Association's learn to play go /</span> </title> Regards Didier Argh. You are right, I missed the change to the title tag that can't contain other HTML tags. I will try to provide a follow up if David doesn't beat me to it. backported to 20.05.x for 20.05.01 Hi Lucas please revert, this will cause issues in display. We need a follow-up first. See Bug 25804 Thanks Cait, This patchset has been reverted from 20.05.x enhancement, not backported to 19.11.x (In reply to Aleisha Amohia from comment #17) > enhancement, not backported to 19.11.x One could argue that this makes some strings translatable as well, so a mix of an enhancement and a bugfix. (In reply to Tomás Cohen Arazi from comment #18) > (In reply to Aleisha Amohia from comment #17) > > enhancement, not backported to 19.11.x > > One could argue that this makes some strings translatable as well, so a mix > of an enhancement and a bugfix. Hm, I don't think that's the case here - strings will change from the different formatting, but all should have translated ok before. backported to 20.05.x for 20.05.02 along with bz25804 enhancement, not backported to 19.11.x. This is great :D could we have the same for OPAC ? |