Bug 12099

Summary: process_message_queue.pl tells it sends print mails even if it doesn't.
Product: Koha Reporter: Olli-Antti Kivilahti <olli-antti.kivilahti>
Component: Command-line UtilitiesAssignee: Olli-Antti Kivilahti <olli-antti.kivilahti>
Status: Failed QA --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart, mtompset
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: pätch

Description Olli-Antti Kivilahti 2014-04-17 08:56:20 UTC
When running the cronjob in verbose mode, such warnings are generated:
sending print message to patron: 1008537 at /home/kivilahtio/koha/kohaclone/C4/Letters.pm line 754.
sending print message to patron: 1049202 at /home/kivilahtio/koha/kohaclone/C4/Letters.pm line 754.
sending print message to patron: 1015993 at /home/kivilahtio/koha/kohaclone/C4/Letters.pm line 754.
sending print message to patron: 1048403 at /home/kivilahtio/koha/kohaclone/C4/Letters.pm line 754.

When collecting cronjob output to log files, this irks me off because it actually doesn't do anything.

As a convenience, a patch is provided to simply warn when something is actually done, or tried to do.
Comment 1 Olli-Antti Kivilahti 2014-08-28 08:38:06 UTC
Created attachment 31234 [details] [review]
pätch

Made the C4::Letters::SendQueuedMessages() notify all but 'print' messages in verbose mode.
This way verbose mode provides a bit cleaner output.
Comment 2 Mark Tompsett 2015-04-28 00:30:37 UTC
So, test plan?
Comment 3 Jonathan Druart 2015-12-28 15:20:17 UTC
I don't think this is relevant, please detail the need.