Bug 12109

Summary: Authority subfield configuration page for controlled fields is broken
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: TemplatesAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: jonathan.druart, tomascohen
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 12109: Fix tab on the auth subfield configuration page
Bug 12109: Fix tab on the auth subfield configuration page
[PASSED QA] Bug 12109: Fix tab on the auth subfield configuration page

Description Katrin Fischer 2014-04-19 10:35:45 UTC
To reproduce:

1) Go to Administration > Authority types
2) Open subfields configuration for one of the controlled fields
3) Verify that the new tab is not shown on top, but at the bottom of the page
[+] Comment 1 Jonathan Druart 2015-04-27 15:25:06 UTC Comment hidden (obsolete)
[+] Comment 2 Mark Tompsett 2015-04-29 06:32:54 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2015-04-29 21:33:06 UTC
Created attachment 38701 [details] [review]
[PASSED QA] Bug 12109: Fix tab on the auth subfield configuration page

There is a condition in the template to not display the "New" tab if the
user is editing a control field.
But it results in a broken template.
Looking at the biblio frameworks, the New tab exists even for control
fields.

This patch only fixes the html structure, but a complete fix should be
provide, for auth and biblio, if we want not to let the ability to
create subfields for control fields.

Test plan:
Edit subfields for a control field
(admin/marc_subfields_structure.pl?op=add_form&tagfield=001&frameworkcode= for instance)
and confirm that the view is now fixed.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

NOTE: Checked LDR, 001, and 008.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2015-05-18 15:15:06 UTC
Patch pushed to master.

Thanks Jonathan!