Description
Mathieu Saby
2014-04-19 18:54:08 UTC
Created attachment 27311 [details] [review] [PATCH] Bug 12111: Improving templates regarding order notes This bug changes some lines in modordernotes.tt to make them more easily translatable, especially in german (remark by K. Fisher on bug 9416). No change should be visible It also suppresses the ability to edit order "vendor note" in reception, as the note for vendor is not made to be changed after the document is received. Test plan : - in a basket, try to edit the notes (internal and vendor) of order. Check the display is correct - go in reception module (parcel.pl page) : in the list of all orders to receive, you must have a link to change "internal note", but no more link to change "vendor note" - try to receive a specific order which have a "vendor note". On the right panel of the page, you must have an editable textarea for internal note, and a non-editable (colored in grey) textarea for vendor note Small nitpick: "Change order vendor note vendor note" - note the doubled "vendor note" Comment on attachment 27311 [details] [review] [PATCH] Bug 12111: Improving templates regarding order notes Review of attachment 27311 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/modordernotes.tt @@ +1,2 @@ > [% INCLUDE 'doc-head-open.inc' %] > +<title>Koha › Acquisition › [% IF (type == "vendor") %]Change order vendor note vendor note[% ELSE %]Change order internal note[% END %]</title> vendor note vendor note? I think that's wrong. Also, please consider using [%- and -%] as needed to make it more readable and still nicely output, rather than jamming it all onto one line. A minus beside the [% or %] prevents spacing from happening. oups, I wrote it to quickly :( I'll fix that this week end Mathieu Created attachment 27649 [details] [review] [PATCH 2/2] Bug 12111 - QA followup : fix breadcrumbs wording for vendor note As asked by QAer, this followup fixes wording in modordernotes.tt for vendor note (Change order vendor note vendor note => Change order vendor note) It also uses [%- and -%] to make code more readable Test plan : try to edit a vendor note, check the wording is correct in breadcrumbs Created attachment 27661 [details] [review] [PASSED QA] Bug 12111: Improving templates regarding order notes This bug changes some lines in modordernotes.tt to make them more easily translatable, especially in german (remark by K. Fisher on bug 9416). No change should be visible It also suppresses the ability to edit order "vendor note" in reception, as the note for vendor is not made to be changed after the document is received. Test plan : - in a basket, try to edit the notes (internal and vendor) of order. Check the display is correct - go in reception module (parcel.pl page) : in the list of all orders to receive, you must have a link to change "internal note", but no more link to change "vendor note" - try to receive a specific order which have a "vendor note". On the right panel of the page, you must have an editable textarea for internal note, and a non-editable (colored in grey) textarea for vendor note Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Created attachment 27662 [details] [review] [PASSED QA] Bug 12111 - QA followup : fix breadcrumbs wording for vendor note As asked by QAer, this followup fixes wording in modordernotes.tt for vendor note (Change order vendor note vendor note => Change order vendor note) It also uses [%- and -%] to make code more readable Test plan : try to edit a vendor note, check the wording is correct in breadcrumbs Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, should be nicely translatable now. Pushed to master, along with a follow-up that replaces the textarea with a span when displaying the vendor note on the order receiving page. Thanks, Mathieu! Thank you. I had a doubt between using a span or a textarea, but I saw an other readonly textarea in the template... Created attachment 29576 [details] Bug 12111: (follow-up) fix breadcrumbs wording for vendor note As asked by QAer, this followup fixes wording in modordernotes.tt for vendor note (Change order vendor note vendor note => Change order vendor note) It also uses [%- and -%] to make code more readable Test plan : try to edit a vendor note, check the wording is correct in breadcrumbs Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, should be nicely translatable now. Signed-off-by: Galen Charlton <gmc@esilibrary.com> I'm sorry for the last comment, I've done a mistake with git bz (In reply to Galen Charlton from comment #8) > Pushed to master, Possible selection for 3.16.x |