Summary: | Incorrect DataTable types in Holds to Pull list | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Templates | Assignee: | David Cook <dcook> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11502 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 12088 | ||
Attachments: |
Bug 12127 - Incorrect DataTable types in Holds to Pull list
[SIGNED-OFF] Bug 12127 - Incorrect DataTable types in Holds to Pull list [PASSED QA] Bug 12127 - Incorrect DataTable types in Holds to Pull list |
Description
David Cook
2014-04-23 05:48:05 UTC
Created attachment 27449 [details] [review] Bug 12127 - Incorrect DataTable types in Holds to Pull list This patch explicitly sets the sType in the Holds to Pull list table for the libraries, itypes, and locations columns. It appears that the type is automatically being set to "html" when it should be set to "string". It needs to have a sType of "string", since DataTables will strip out the <br> tags when using "html", and we need them for the regexp we use to create a more precise filter search. _TEST PLAN_ Before applying: 1) Place a "next available" hold on a record with an item available from one library/branch (e.g. "Branch A") 2) Place a "next available" hold on a record with an item available from two different libraries/branches 3) Place a "next available" hold on a record with an item available from three different libraries/branches - one of which is the same as the library/branch from Step 1. 4) Go to the Holds to Pull List 5) Filter the branches by "Branch A". 6) You should only see the hold from Step 1 - not Step 3. 7) Try filtering on a branch for a hold that has multiple libraries/branches. (They shouldn't appear when filtering, except when using the "None" filter). Apply the patch. After applying: 1) Repeat Steps 4-7 from above. When filtering on "Branch A", you should be able to see all holds that are available at "Branch A", even if they are available at other branches (i.e. the holds has multiple libraries listed). Created attachment 27481 [details] [review] [SIGNED-OFF] Bug 12127 - Incorrect DataTable types in Holds to Pull list This patch explicitly sets the sType in the Holds to Pull list table for the libraries, itypes, and locations columns. It appears that the type is automatically being set to "html" when it should be set to "string". It needs to have a sType of "string", since DataTables will strip out the <br> tags when using "html", and we need them for the regexp we use to create a more precise filter search. _TEST PLAN_ Before applying: 1) Place a "next available" hold on a record with an item available from one library/branch (e.g. "Branch A") 2) Place a "next available" hold on a record with an item available from two different libraries/branches 3) Place a "next available" hold on a record with an item available from three different libraries/branches - one of which is the same as the library/branch from Step 1. 4) Go to the Holds to Pull List 5) Filter the branches by "Branch A". 6) You should only see the hold from Step 1 - not Step 3. 7) Try filtering on a branch for a hold that has multiple libraries/branches. (They shouldn't appear when filtering, except when using the "None" filter). Apply the patch. After applying: 1) Repeat Steps 4-7 from above. When filtering on "Branch A", you should be able to see all holds that are available at "Branch A", even if they are available at other branches (i.e. the holds has multiple libraries listed). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 27609 [details] [review] [PASSED QA] Bug 12127 - Incorrect DataTable types in Holds to Pull list This patch explicitly sets the sType in the Holds to Pull list table for the libraries, itypes, and locations columns. It appears that the type is automatically being set to "html" when it should be set to "string". It needs to have a sType of "string", since DataTables will strip out the <br> tags when using "html", and we need them for the regexp we use to create a more precise filter search. _TEST PLAN_ Before applying: 1) Place a "next available" hold on a record with an item available from one library/branch (e.g. "Branch A") 2) Place a "next available" hold on a record with an item available from two different libraries/branches 3) Place a "next available" hold on a record with an item available from three different libraries/branches - one of which is the same as the library/branch from Step 1. 4) Go to the Holds to Pull List 5) Filter the branches by "Branch A". 6) You should only see the hold from Step 1 - not Step 3. 7) Try filtering on a branch for a hold that has multiple libraries/branches. (They shouldn't appear when filtering, except when using the "None" filter). Apply the patch. After applying: 1) Repeat Steps 4-7 from above. When filtering on "Branch A", you should be able to see all holds that are available at "Branch A", even if they are available at other branches (i.e. the holds has multiple libraries listed). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> It would be nice if this patch used classes right from the start, but it's still better than having a bug! (In reply to Kyle M Hall from comment #4) > It would be nice if this patch used classes right from the start My patch for Bug 12088 corrects this. Pushed to master. Thanks, David! |