Bug 12131

Summary: C4/TmplToken.pm has an unnecessary dependency on Exporter
Product: Koha Reporter: Colin Campbell <colin.campbell>
Component: Architecture, internals, and plumbingAssignee: Colin Campbell <colin.campbell>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: gmcharlt
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: proposed patch
Bug 12131: Remove unused dependency on Exporter
[PASSED QA] Bug 12131: Remove unused dependency on Exporter

Description Colin Campbell 2014-04-23 13:21:47 UTC
TmplToken has a dependency on Exporter but does not export anything all subroutines being called via a TmplToken object looks like a bit of boilerplate got in the module. Lets remove that and the "burden" of compiling it every time
Comment 1 Colin Campbell 2014-04-23 13:30:00 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2014-04-24 06:47:14 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall (khall) 2014-04-25 11:23:41 UTC
Created attachment 27608 [details] [review]
[PASSED QA] Bug 12131: Remove unused dependency on Exporter

C4::TmplToken depends on Exporter but does not use any
of its facilities. Removed the dead code so it does not
clog up the source and waste compilation time

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Module still compiles correctly; t/TmplToken.t passes.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Galen Charlton 2014-04-25 15:38:07 UTC
Pushed to master.  Thanks, Colin!