Summary: | hiding alternate address on patron self registration doesn't hide heading | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | OPAC | Assignee: | Jacek Ablewicz <abl> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | abl, chris, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 12143 - hiding alternate address on patron self registration doesn't hide heading
Bug 12143 - hiding alternate address on patron self registration doesn't hide heading [PASSED QA] Bug 12143 - hiding alternate address on patron self registration doesn't hide heading |
Description
Nicole C. Engard
2014-04-25 14:33:33 UTC
Created attachment 29164 [details] [review] Bug 12143 - hiding alternate address on patron self registration doesn't hide heading This patch fixes the following issue: in OPAC self registration form, even if all alternate address fields are configured as hidden, the heading for "Alternate address" still shows. To test: 1/ Confirm the issue: hide all alternate adres field names (i.e., enter B_address|B_address2|B_city|B_state|B_zipcode|B_country|B_phone| B_email|contactnote into PatronSelfRegistrationBorrowerUnwantedField system prefrence). 2/ Observe that "Alternate address" section heading still shows in patron self registration form ("your personal details" tab), despite that all section fields are configured as hidden. 3/ Apply patch. 4/ Reload OPAC self registration form; confirm that "Alternate address" is not displyed any longer, and the issue is now fixed. 5/ Remove some field name (e.g. B_address2) from PatronSelfRegistrationBorrowerUnwantedField; ensure that "Alternate address" heading does show if at least one section field is not hidden. 6/ Test steps 1-5 should be performed/repeated in both bootstrap and prog OPAC themes. Created attachment 29170 [details] [review] Bug 12143 - hiding alternate address on patron self registration doesn't hide heading This patch fixes the following issue: in OPAC self registration form, even if all alternate address fields are configured as hidden, the heading for "Alternate address" still shows. To test: 1/ Confirm the issue: hide all alternate adres field names (i.e., enter B_address|B_address2|B_city|B_state|B_zipcode|B_country|B_phone| B_email|contactnote into PatronSelfRegistrationBorrowerUnwantedField system prefrence). 2/ Observe that "Alternate address" section heading still shows in patron self registration form ("your personal details" tab), despite that all section fields are configured as hidden. 3/ Apply patch. 4/ Reload OPAC self registration form; confirm that "Alternate address" is not displyed any longer, and the issue is now fixed. 5/ Remove some field name (e.g. B_address2) from PatronSelfRegistrationBorrowerUnwantedField; ensure that "Alternate address" heading does show if at least one section field is not hidden. 6/ Test steps 1-5 should be performed/repeated in both bootstrap and prog OPAC themes. Followed test plan with prog and bootstrap themes, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 29187 [details] [review] [PASSED QA] Bug 12143 - hiding alternate address on patron self registration doesn't hide heading This patch fixes the following issue: in OPAC self registration form, even if all alternate address fields are configured as hidden, the heading for "Alternate address" still shows. To test: 1/ Confirm the issue: hide all alternate adres field names (i.e., enter B_address|B_address2|B_city|B_state|B_zipcode|B_country|B_phone| B_email|contactnote into PatronSelfRegistrationBorrowerUnwantedField system prefrence). 2/ Observe that "Alternate address" section heading still shows in patron self registration form ("your personal details" tab), despite that all section fields are configured as hidden. 3/ Apply patch. 4/ Reload OPAC self registration form; confirm that "Alternate address" is not displyed any longer, and the issue is now fixed. 5/ Remove some field name (e.g. B_address2) from PatronSelfRegistrationBorrowerUnwantedField; ensure that "Alternate address" heading does show if at least one section field is not hidden. 6/ Test steps 1-5 should be performed/repeated in both bootstrap and prog OPAC themes. Followed test plan with prog and bootstrap themes, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Simple typo fix, that fixes a nasty bug. Pushed to Master as MM OPAC .. thanks for the patch Jacek |