Bug 12150

Summary: Use more placeholders in translatable javascript strings
Product: Koha Reporter: paxed <pasi.kallinen>
Component: I18N/L10NAssignee: paxed <pasi.kallinen>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: bgkriegel, f.demians, jonathan.druart, tomascohen
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Make more translatable javascript strings in intranet use the js string formatter.
[SIGNED-OFF] Bug 12150 - Use more javascript string formatting in intranet for translated strings.
Bug 12150 - Use more javascript string formatting in intranet for translated strings.
Bug 12150: Add missing space and correct innerHTML typo

Description paxed 2014-04-28 05:53:19 UTC Comment hidden (obsolete)
Comment 1 Bernardo Gonzalez Kriegel 2014-05-01 23:19:36 UTC
Is ready to be signed?
Comment 2 paxed 2014-05-05 06:04:40 UTC
(In reply to Bernardo Gonzalez Kriegel from comment #1)
> Is ready to be signed?

Yes, sorry, forgot to change the status.
Comment 3 Owen Leonard 2014-05-06 14:52:44 UTC
This needs a detailed test plan.
Comment 4 Bernardo Gonzalez Kriegel 2014-06-09 12:51:52 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2014-06-11 10:49:23 UTC
Created attachment 28774 [details] [review]
Bug 12150 - Use more javascript string formatting in intranet for translated strings.

http://bugs.koha-community.org/show_bug.cgi?id=12150

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

No bug number on description
No commit message
No test plan
No koha-qa errors

I only signed this because it's useful for translations
but we can live without it, so is up to QA now

Tested some easy messages (e.g. syspref saving), and
updated PO files to check new strings.
Inspected the code, I think that there are no errors.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 6 Jonathan Druart 2014-06-11 10:49:27 UTC
Created attachment 28775 [details] [review]
Bug 12150: Add missing space and correct innerHTML typo

The previous patch forgot to add a space between the string "Edit
action" and the placeholder.

Trying to test it, I found a typo: innerhtml does not exist, it should
be innerHTML.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 7 Jonathan Druart 2014-06-11 10:50:48 UTC
I didn't test everything, but all looks good.

It would be great to have the same kind of patch for the opac bootstrap theme.
Comment 8 Tomás Cohen Arazi (tcohen) 2014-07-03 13:21:13 UTC
No regressions found, patches pushed to master.

Thanks paxed!