Summary: | Add description of charges (bug 2546) to Bootstrap OPAC | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | I18N/L10N | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | f.demians, gmcharlt, jonathan.druart, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 2546 | ||
Bug Blocks: | |||
Attachments: |
Bug 12165: Add descriptions of charges (bug 2546) to Bootstrap Opac theme
[Signed-off] Bug 12165: Add descriptions of charges (bug 2546) to Bootstrap Opac theme Bug 12165: Add descriptions of charges (bug 2546) to Bootstrap Opac theme Bug 12165: Display record title |
Description
Katrin Fischer
2014-04-30 17:41:59 UTC
Created attachment 27821 [details] [review] Bug 12165: Add descriptions of charges (bug 2546) to Bootstrap Opac theme 1) Create an account with lots of different charges, fines, fees, etc. 2) Look at the accouts tab in the prog OPAC theme 3) Compare the page to bootstrap theme 4) Verify display is now the same In my tests I found some things that could still be improved, but for the goal is to make all OPAC themes behave the same. Created attachment 27879 [details] [review] [Signed-off] Bug 12165: Add descriptions of charges (bug 2546) to Bootstrap Opac theme 1) Create an account with lots of different charges, fines, fees, etc. 2) Look at the accouts tab in the prog OPAC theme 3) Compare the page to bootstrap theme 4) Verify display is now the same In my tests I found some things that could still be improved, but for the goal is to make all OPAC themes behave the same. Tested by changing accounttype in table accountlines to all possible values like Pay, Pay00, Pay01 etc. Both themes display the same values, e.g. "Payment, thanks (cash via SIP2)" for Pay00 Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 28100 [details] [review] Bug 12165: Add descriptions of charges (bug 2546) to Bootstrap Opac theme 1) Create an account with lots of different charges, fines, fees, etc. 2) Look at the accouts tab in the prog OPAC theme 3) Compare the page to bootstrap theme 4) Verify display is now the same In my tests I found some things that could still be improved, but for the goal is to make all OPAC themes behave the same. Tested by changing accounttype in table accountlines to all possible values like Pay, Pay00, Pay01 etc. Both themes display the same values, e.g. "Payment, thanks (cash via SIP2)" for Pay00 Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 28101 [details] [review] Bug 12165: Display record title The code introduced by bug 2546 uses an undefined variable (line.title). It should be ACCOUNT_LINE.title. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master and 3.16.x. Thanks, Katrin! |